Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #317 - Make namespace an optional parameter when generating manifests in workflowproj #320

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

ricardozanini
Copy link
Member

Description of the change:
Fixes #317

Motivation for the change:

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

… manifests in workflowproj

Signed-off-by: Ricardo Zanini <zanini@redhat.com>
@ederign
Copy link
Member

ederign commented Dec 13, 2023

@ricardozanini, here is the CLI companion jira: https://issues.redhat.com/browse/KOGITO-9990 . As soon as I start to work on this, I'll convert it to a GH issue.

@ederign ederign merged commit 3b5108c into apache:main Dec 13, 2023
4 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-serverless-operator that referenced this pull request Jan 29, 2024
… manifests in workflowproj (apache#320)

Signed-off-by: Ricardo Zanini <zanini@redhat.com>
rgdoliveira pushed a commit to rgdoliveira/kogito-serverless-operator that referenced this pull request Jan 29, 2024
… manifests in workflowproj (apache#320)

Signed-off-by: Ricardo Zanini <zanini@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow creating resources without specifying a namespace
3 participants