PLANNER-409: Name benchmark directories uniquely + test #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailing when it finds an existing directory of the same name
| if (!benchmarkReportDirectoryAdded) { | ||
| throw new IllegalArgumentException("The benchmarkReportDirectory (" + benchmarkReportDirectory | ||
| + ") creation failed. It probably already exists."); | ||
| if (!benchmarkDirectory.mkdirs()) { |
There was a problem hiding this comment.
The if and while condition aren't just read methods, they also have the side-effect of making the directory. That can hurt readability / code expectations, although it's very debatable too.
For consistency with the rest of optaplanner code, would you mind creating a boolean variable as in the original code?
There was a problem hiding this comment.
Nevermind this. It's too debatable indeed.
ge0ffrey
added a commit
that referenced
this pull request
Aug 21, 2015
PLANNER-409: Name benchmark directories uniquely + test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.