KOGITO-10058: Migrate serverless-workflow-diagram-editor from private to KIE repos and libs #2169
Conversation
treblereel
requested review from
ederign,
tiagobento and
paulovmr
as code owners
treblereel
force-pushed
the
migrate_to_j2cl_tools
branch
from
4057aad
to
c827c2a
Compare
ederign
requested review from
caponetto and
handreyrc
and removed request for
tiagobento
caponetto
changed the title
|
Hello @treblereel , could you please provide the details about the changes in related issue/jira? Thank you! |
treblereel
force-pushed
the
migrate_to_j2cl_tools
branch
from
c827c2a
to
c98b39a
Compare
There was a problem hiding this comment.
Hello @treblereel ,
org.treblereel.* dependencies were not removed from YARD editor.
Please see also my KOGITO-10058-comment
Other than that, all integration tests passed and I didn't find any issues.
Thank you!
I think we should ask Eder and Mark to clarify this, but as far as I remember from our discussion, it's because of the Apache license: we can't move to Apache projects created by third parties. Yard is @Rikkola 's project, so I think we can ask him to update the deps. I have informed him already that we published libs to jboss/sonatype so maybe we can just wait for him. |
|
Hello @treblereel , KOGITO-10058 scope is to remove all dependencies from kie-tools repository. If you want to split the work with @Rikkola , we can do that, but we need to update the scope of the jira and report remaining work in a separate issue. Do you want to split the work? |
|
One more note to my previous comment. Alternatively, we can keep the scope of the jira the same, and link multiple PRs there, or use more commits in this PR and involve Toni here. |
|
The model from YARD editor is going to move to incubator-kie-drools after 10.0.0. During the move I was planning to swap the treblereel yaml mapper dependency. If this needs to be done before 10.0.0, then I can swap it now. |
|
@Rikkola, @treblereel , how do you want to address the dependencies not removed from YARD editor? See my previous comments. Thanks! |
|
@Rikkola I think it should be done before 10.0.0 release, so there are no third party libraries references in the repository. |
|
@LuboTerifaj @treblereel I can do the change. There will be some manual testing needed, so I will be the fastest one to do it. |
|
@Rikkola thank you, all green ! |
|
np |
There was a problem hiding this comment.
@treblereel , @Rikkola , can you please remove this file?
There was a problem hiding this comment.
True, it should be removed.
removing spam file
There was a problem hiding this comment.
Thanks for the updates @treblereel , @Rikkola . It looks good to me now.
jira: https://issues.redhat.com/browse/KOGITO-10058