-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kie-issues#833: Move all UI packages from kogito-apps
to kie-tools
#2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagoelg
requested review from
ederign,
tiagobento and
paulovmr
as code owners
February 23, 2024 12:36
packages/runtime-tools-process-dev-ui-webapp/server/MockData/controllers.js
Dismissed
Show dismissed
Hide dismissed
packages/runtime-tools-process-dev-ui-webapp/server/MockData/controllers.js
Dismissed
Show dismissed
Hide dismissed
packages/runtime-tools-process-dev-ui-webapp/server/MockData/controllers.js
Dismissed
Show dismissed
Hide dismissed
packages/runtime-tools-management-console-webapp/server/MockData/controllers.js
Dismissed
Show dismissed
Hide dismissed
packages/runtime-tools-process-dev-ui-webapp/server/MockData/controllers.js
Dismissed
Show dismissed
Hide dismissed
packages/runtime-tools-process-dev-ui-webapp/server/server.js
Dismissed
Show dismissed
Hide dismissed
packages/runtime-tools-process-dev-ui-webapp/server/server.js
Dismissed
Show dismissed
Hide dismissed
packages/runtime-tools-process-dev-ui-webapp/server/server.js
Dismissed
Show dismissed
Hide dismissed
packages/runtime-tools-process-dev-ui-webapp/server/MockData/controllers.js
Dismissed
Show dismissed
Hide dismissed
packages/runtime-tools-process-dev-ui-webapp/server/MockData/controllers.js
Dismissed
Show dismissed
Hide dismissed
* RUNTIME_TOOLS_PROCESS_DEV_UI_WEBAPP__kogitoAppUrl: allows devUI to connect to a remote kogito application (default empty) * RUNTIME_TOOLS_PROCESS_DEV_UI_WEBAPP__openApiDocPath: allows configuring the path to the openapi doc (default /q/openapi.json)
pefernan
force-pushed
the
kogito-apps-migration
branch
from
March 28, 2024 09:41
023339f
to
fd77544
Compare
tiagobento
approved these changes
Mar 28, 2024
7 tasks
fantonangeli
pushed a commit
to fantonangeli/kie-tools
that referenced
this pull request
Apr 23, 2024
apache#2180) Co-authored-by: Pere Fernández <pefernan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: apache/incubator-kie-issues#833
Summary of the migration
Migrated packages from kogito-apps:
All dependencies of those packages that weren't previously migrated were migrated as well and were distributed across the new or renamed packages:
Unit and end-to-end tests
Most unit tests were stripped out of those packages since they weren't really testing anything.
End-to-end tests were also stripped out but may come back at a later stage, they were not considered right now due to the time it would take to set it up.
Testing and validating this PR locally
Follow the steps below:
To fetch the branch from my fork without adding my fork as a remote, use this command:
then checkout the
kogito-apps-migration
branch.Build the new packages with:
Then run them individually:
You may also run the
dev
command instead ofstart
to use the mock server (in this case, setting the environment variable is not necessary).