KOGITO-5522: Incorporate kogito-editors-java
#729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* switched to elemental2 Blob implementation * formating
…r differently on read-only mode (#31)
* BXMSPROD-1311 action-surefire-report * Check Surefire Report errata fixed
* BXMSPROD-1311 action-surefire-report * Check Surefire Report errata fixed
…#37) * KOGITO-4872: Add ErrorPage for SceSim. * KOGITO-4872: Fix associated test.
Co-authored-by: karreiro <karreiro@users.noreply.github.com>
…n use click property first time (#15)
…select nodes cherry-pick (#47) Co-authored-by: Jaime Enriquez <jenrique@redhat.com>
… empty (#36) If an item could not be found in the workiItemDefinitionRegistry a null exception was thrown interrupting the load process.
* Update ci_full_downstream_build.yml * Fix FDB workflow
…magnetic point (#18)
jomarko
pushed a commit
to jomarko/kie-tools
that referenced
this pull request
Jan 6, 2022
This changes are related to monorepo migration apache#729
jomarko
pushed a commit
to jomarko/kie-tools
that referenced
this pull request
Jan 6, 2022
This changes are related to monorepo migration apache#729
jomarko
pushed a commit
to jomarko/kie-tools
that referenced
this pull request
Jan 6, 2022
This changes are related to monorepo migration apache#729
jomarko
pushed a commit
to jomarko/kie-tools
that referenced
this pull request
Jan 6, 2022
This changes are related to monorepo migration apache#729
jomarko
pushed a commit
to jomarko/kie-tools
that referenced
this pull request
Jan 6, 2022
This changes are related to monorepo migration apache#729
|
@jomarko They are not running on |
|
@tiagobento I can not agree, there were part of regular CI build on |
|
@jomarko Ok, you're right. Let's enable them. |
jomarko
pushed a commit
to jomarko/kie-tools
that referenced
this pull request
Jan 6, 2022
This changes are related to monorepo migration apache#729
jomarko
pushed a commit
to jomarko/kie-tools
that referenced
this pull request
Jan 6, 2022
This changes are related to monorepo migration apache#729
jomarko
pushed a commit
to jomarko/kie-tools
that referenced
this pull request
Jan 6, 2022
This changes are related to monorepo migration apache#729
jomarko
pushed a commit
to jomarko/kie-tools
that referenced
this pull request
Jan 7, 2022
This changes are related to monorepo migration apache#729
jomarko
pushed a commit
to jomarko/kie-tools
that referenced
this pull request
Jan 7, 2022
This changes are related to monorepo migration apache#729
This changes are related to monorepo migration apache#729
yesamer
approved these changes
Jan 10, 2022
There was a problem hiding this comment.
@tiagobento Thank you for this huge work. After the merge, I think it's crucial to inform the team about the new commands you introduced and their usage, in order to avoid full compilation in local builds.
tiagobento
changed the title
kogito-editors-javakogito-editors-java
|
Thank you @tiagobento for bringing back most of |
jomarko
approved these changes
Jan 11, 2022
romartin
approved these changes
Jan 11, 2022
ederign
approved these changes
Jan 11, 2022
radtriste
pushed a commit
to apache/incubator-kie-kogito-pipelines
that referenced
this pull request
Jan 11, 2022
* Activate jenkins PR jobs for kogito-tooling This change is needed due to monorepo-migration: - apache/incubator-kie-tools#729 * Temporal changes to debug new Jenkins job * Revert "Temporal changes to debug new Jenkins job" This reverts commit 35c9512.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates the
kogito-editors-javarepository into the kogito-tooling monorepo.The entire repository was placed inside the
stunner-editorsdirectory.The directory structure is kept identical, except for the
kogito-editors-jspackage, which was hoisted into the top level of the monorepo. This avoids nested lerna builds and encourages reusability and enhances the separation of concerns of our packages. The names are kept, with the exception ofdmn-loader, which is now calledstunner-editors-dmn-loader.I also removed the
yarn build:devandyarn build:prodcommands, as we should begin to choose what we want to build. Two new commands were created --yarn build:dev:until [pkg-name]andyarn build:prod:until [pkg-name].Of course building everything is still supported with
lerna run build:devandlerna run build:prod.Some changes were made to the way the
DMN Loaderpackage is configured. Thewireenv var was renamed toDMN_LOADER__outputPathand is now managed bybuild-env, just like all the other env vars we have.Maven commands still work normally inside
packages/stunner-editors.The envisioned workflow for Editor developers is
Something that also changed is how we load CSS for React components inside the DMN Editor. The CSS was separate from the JS bundle in production builds. Although this the ideal thing to do, it gives us some challenges due to the discrepancy between dev and prod builds. For this reason, I changed the DMN Loader to use our default Webpack configuration, so everything works the same now. This is an important optimization issue and we're aware that this could be considered a "step back", however, having everything on the same repository is far more important at this time.
I already contacted Jozef and Dominik about the QE builds/checks we have, so this PR can still be updated once I have more information.