Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade rocksdb to v7.7.3 #1056

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Conversation

xiaobiaozhao
Copy link
Contributor

No description provided.

@tanruixiang
Copy link
Member

I suggest putting the test results and conclusions here or in the issue.

@xiaobiaozhao
Copy link
Contributor Author

I suggest putting the test results and conclusions here or in the issue.

Here is a simple test report

#1013 (comment)

@caipengbo caipengbo changed the title feat: Upgrade rocksdb to v7.7.5 feat: Upgrade rocksdb to v7.7.3 Nov 1, 2022
@git-hulk
Copy link
Member

git-hulk commented Nov 1, 2022

I think we can push forward to upgrading since the RocksDB community has confirmed the bad performance when compacting in 6.x and fixed in 7.5.3. Related issue: facebook/rocksdb#9423

Copy link
Contributor

@caipengbo caipengbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, LGTM!
Rocksdb 7.x has some new features that maybe we can add to kvrocks(like blob cache)

Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tisonkun tisonkun merged commit 684bcc6 into apache:unstable Nov 1, 2022
@tisonkun
Copy link
Member

tisonkun commented Nov 1, 2022

Merged. Thank you!

git-hulk added a commit that referenced this pull request Nov 2, 2022
yanghonggang pushed a commit to yanghonggang/ceph that referenced this pull request Nov 21, 2022
- RocksDB community has confirmed the bad performance when compacting in 6.x and fixed in 7.5.3
  * facebook/rocksdb#9423
  * apache/kvrocks#1056
- new features(e.g., wal compression)

Signed-off-by: Yang Honggang <yanghonggang_yewu@cmss.chinamobile.com>
yanghonggang pushed a commit to yanghonggang/ceph that referenced this pull request Nov 21, 2022
- RocksDB community has confirmed the bad performance when compacting in 6.x and fixed in 7.5.3
  * facebook/rocksdb#9423
  * apache/kvrocks#1056
- new features(e.g., wal compression)

Signed-off-by: Yang Honggang <yanghonggang_yewu@cmss.chinamobile.com>
yanghonggang pushed a commit to yanghonggang/ceph that referenced this pull request Dec 27, 2022
- RocksDB community has confirmed the bad performance when compacting in 6.x and fixed in 7.5.3
  * facebook/rocksdb#9423
  * apache/kvrocks#1056
- new features(e.g., wal compression)

Signed-off-by: Yang Honggang <yanghonggang_yewu@cmss.chinamobile.com>
yanghonggang pushed a commit to yanghonggang/ceph that referenced this pull request Feb 13, 2023
- RocksDB community has confirmed the bad performance when compacting in 6.x and fixed in 7.5.3
  * facebook/rocksdb#9423
  * apache/kvrocks#1056
- new features(e.g., wal compression)

Signed-off-by: Yang Honggang <yanghonggang_yewu@cmss.chinamobile.com>
dparmar18 pushed a commit to dparmar18/ceph that referenced this pull request Mar 1, 2023
- RocksDB community has confirmed the bad performance when compacting in 6.x and fixed in 7.5.3
  * facebook/rocksdb#9423
  * apache/kvrocks#1056
- new features(e.g., wal compression)

Signed-off-by: Yang Honggang <yanghonggang_yewu@cmss.chinamobile.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants