Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Add maven profile spark-3.2 #1228

Closed
wants to merge 3 commits into from
Closed

Conversation

pan3793
Copy link
Member

@pan3793 pan3793 commented Oct 14, 2021

Why are the changes needed?

Support Spark 3.2.0.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@pan3793 pan3793 marked this pull request as draft October 14, 2021 01:46
@pan3793 pan3793 mentioned this pull request Oct 14, 2021
14 tasks
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2021

Codecov Report

Merging #1228 (77674a0) into master (f03a144) will increase coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head 77674a0 differs from pull request most recent head 8f2dfd0. Consider uploading reports for the commit 8f2dfd0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1228   +/-   ##
=========================================
  Coverage     73.10%   73.10%           
  Complexity       41       41           
=========================================
  Files           175      175           
  Lines          6848     6849    +1     
  Branches        835      835           
=========================================
+ Hits           5006     5007    +1     
  Misses         1441     1441           
  Partials        401      401           
Impacted Files Coverage Δ
...he/kyuubi/engine/spark/shim/SparkCatalogShim.scala 78.26% <0.00%> (+1.17%) ⬆️
...g/apache/kyuubi/engine/spark/KyuubiSparkUtil.scala 88.46% <75.00%> (-2.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f03a144...8f2dfd0. Read the comment docs.

@pan3793
Copy link
Member Author

pan3793 commented Oct 19, 2021

cc @yaooqinn @ulysses-you @turboFei, it's ready for review, but should be merged after #757

@pan3793 pan3793 marked this pull request as ready for review October 19, 2021 04:32
@pan3793
Copy link
Member Author

pan3793 commented Oct 19, 2021

Thanks, merging to master

@pan3793 pan3793 closed this in 48f8d29 Oct 19, 2021
@pan3793 pan3793 deleted the 32 branch October 19, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants