Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new config property authentication.ldap.guidKey #712

Closed
wants to merge 2 commits into from

Conversation

lordk911
Copy link
Contributor

for fix issues : #709

my ldap env use cn but uid for login, uid is the defaut behavior by kyuubi :
image

then try to connect kyuubi :
image
image

change kyuubi behavior to use cn:

image

then try to connect kyuubi :

image

@ulysses-you
Copy link
Contributor

thank you for making a PR @lordk911 , welcome to Kyuubi !

@yaooqinn yaooqinn modified the milestones: v1.2.0, v1.3.0 Jun 24, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #712 (0ab1a5b) into branch-1.2 (a6ab236) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           branch-1.2     #712      +/-   ##
==============================================
+ Coverage       80.11%   80.18%   +0.06%     
==============================================
  Files             120      120              
  Lines            4672     4678       +6     
  Branches          563      563              
==============================================
+ Hits             3743     3751       +8     
+ Misses            608      607       -1     
+ Partials          321      320       -1     
Impacted Files Coverage Δ
...in/scala/org/apache/kyuubi/config/KyuubiConf.scala 94.08% <100.00%> (+0.08%) ⬆️
...uthentication/LdapAuthenticationProviderImpl.scala 92.00% <100.00%> (+0.33%) ⬆️
...org/apache/spark/kyuubi/SQLOperationListener.scala 97.43% <0.00%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ab236...0ab1a5b. Read the comment docs.

@ulysses-you
Copy link
Contributor

hi @lordk911 just notice this PR is for branch-1.2, can you change the target to master ? thanks

yaooqinn pushed a commit that referenced this pull request Jun 24, 2021
for fix issues : #709

my ldap env use cn but uid for login, uid is the defaut behavior by kyuubi :
![image](https://user-images.githubusercontent.com/19989300/123198110-23e5f280-d4df-11eb-852e-b002dc6f06b2.png)

then try to connect kyuubi :
![image](https://user-images.githubusercontent.com/19989300/123198301-6f000580-d4df-11eb-8ff8-fc0687bfc18a.png)
![image](https://user-images.githubusercontent.com/19989300/123198383-98209600-d4df-11eb-943f-554b4077eba6.png)

change kyuubi behavior to use cn:

![image](https://user-images.githubusercontent.com/19989300/123198493-c900cb00-d4df-11eb-9d6b-2a717010523b.png)

then try to connect kyuubi :

![image](https://user-images.githubusercontent.com/19989300/123198615-01080e00-d4e0-11eb-9e6c-c5d84ada3a61.png)

Closes #712 from lordk911/branch-1.2.

Closes #712

0ab1a5b [kshen] add a new config property authentication.ldap.guidKey
24fb1bc [kshen] add a new config property authentication.ldap.guidKey

Authored-by: kshen <kshen@gaojihealth.com>
Signed-off-by: Kent Yao <yao@apache.org>
@yaooqinn yaooqinn closed this in 0bcab19 Jun 24, 2021
@yaooqinn
Copy link
Member

It's better to add kshen@gaojihealth.com to your github settings too @lordk911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants