-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a new config property authentication.ldap.guidKey #712
Conversation
thank you for making a PR @lordk911 , welcome to Kyuubi ! |
Codecov Report
@@ Coverage Diff @@
## branch-1.2 #712 +/- ##
==============================================
+ Coverage 80.11% 80.18% +0.06%
==============================================
Files 120 120
Lines 4672 4678 +6
Branches 563 563
==============================================
+ Hits 3743 3751 +8
+ Misses 608 607 -1
+ Partials 321 320 -1
Continue to review full report at Codecov.
|
hi @lordk911 just notice this PR is for |
for fix issues : #709 my ldap env use cn but uid for login, uid is the defaut behavior by kyuubi : ![image](https://user-images.githubusercontent.com/19989300/123198110-23e5f280-d4df-11eb-852e-b002dc6f06b2.png) then try to connect kyuubi : ![image](https://user-images.githubusercontent.com/19989300/123198301-6f000580-d4df-11eb-8ff8-fc0687bfc18a.png) ![image](https://user-images.githubusercontent.com/19989300/123198383-98209600-d4df-11eb-943f-554b4077eba6.png) change kyuubi behavior to use cn: ![image](https://user-images.githubusercontent.com/19989300/123198493-c900cb00-d4df-11eb-9d6b-2a717010523b.png) then try to connect kyuubi : ![image](https://user-images.githubusercontent.com/19989300/123198615-01080e00-d4e0-11eb-9e6c-c5d84ada3a61.png) Closes #712 from lordk911/branch-1.2. Closes #712 0ab1a5b [kshen] add a new config property authentication.ldap.guidKey 24fb1bc [kshen] add a new config property authentication.ldap.guidKey Authored-by: kshen <kshen@gaojihealth.com> Signed-off-by: Kent Yao <yao@apache.org>
It's better to add kshen@gaojihealth.com to your github settings too @lordk911 |
for fix issues : #709
my ldap env use cn but uid for login, uid is the defaut behavior by kyuubi :
then try to connect kyuubi :
change kyuubi behavior to use cn:
then try to connect kyuubi :