[LIVY-556] HearbeatExpired is not stubbed correctly in test cases #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the proper stubbing to mocked InteractiveSessions. Task-url: https://issues.apache.org/jira/projects/LIVY/issues/LIVY-556
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
============================================
- Coverage 68.79% 68.76% -0.04%
+ Complexity 905 904 -1
============================================
Files 100 100
Lines 5650 5650
Branches 846 846
============================================
- Hits 3887 3885 -2
- Misses 1211 1212 +1
- Partials 552 553 +1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
============================================
- Coverage 68.79% 68.76% -0.04%
+ Complexity 905 904 -1
============================================
Files 100 100
Lines 5650 5650
Branches 846 846
============================================
- Hits 3887 3885 -2
- Misses 1211 1212 +1
- Partials 552 553 +1
Continue to review full report at Codecov.
|
|
LGTM |
|
Merging to master. |
kai-chi
pushed a commit
to logicalclocks/incubator-livy
that referenced
this pull request
Jul 29, 2019
## What changes were proposed in this pull request? Add the proper stubbing to all mocked interactive sessions to make sure session heartbeats work correctly. ## How was this patch tested? This change only fixes the test cases. It is not changing production code. Author: Meisam Fathi <meisam.fathi@gmail.com> Closes apache#143 from meisam/LIVY-556.
kai-chi
pushed a commit
to kai-chi/incubator-livy
that referenced
this pull request
Jul 29, 2019
## What changes were proposed in this pull request? Add the proper stubbing to all mocked interactive sessions to make sure session heartbeats work correctly. ## How was this patch tested? This change only fixes the test cases. It is not changing production code. Author: Meisam Fathi <meisam.fathi@gmail.com> Closes apache#143 from meisam/LIVY-556.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the proper stubbing to all mocked interactive sessions to make sure session heartbeats work correctly.
How was this patch tested?
This change only fixes the test cases. It is not changing production code.