Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVY-694] Upgrade Jetty to 9.4.18.v20190429 #244

Conversation

peter-toth
Copy link
Contributor

@peter-toth peter-toth commented Oct 8, 2019

What changes were proposed in this pull request?

Upgrade Jetty to 9.4.18.v20190429 to fix CVEs.

How was this patch tested?

Existing UTs.

@codecov-io
Copy link

codecov-io commented Oct 8, 2019

Codecov Report

Merging #244 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #244      +/-   ##
============================================
+ Coverage     68.45%   68.52%   +0.06%     
- Complexity      927      928       +1     
============================================
  Files           100      100              
  Lines          5729     5729              
  Branches        870      870              
============================================
+ Hits           3922     3926       +4     
+ Misses         1247     1244       -3     
+ Partials        560      559       -1
Impacted Files Coverage Δ Complexity Δ
...ain/scala/org/apache/livy/utils/SparkYarnApp.scala 67.32% <0%> (+1.3%) 40% <0%> (ø) ⬇️
...in/java/org/apache/livy/rsc/driver/JobWrapper.java 88.57% <0%> (+5.71%) 9% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0804c8e...e70c47b. Read the comment docs.

@mgaido91
Copy link
Contributor

thanks for the patch @peter-toth. I remember there were issues with the thrifserver part due to dependencies on hive which created issues with jetty versions different to the one used earlier. Have you checked that thriftserver works in http mode too with this patch?

@peter-toth
Copy link
Contributor Author

Thanks for letting me know about that issue. I will check it with the updated Jetty version.

@coheigea
Copy link

This PR duplicates an existing PR: https://github.com/apache/incubator-livy/pull/175/files
@peter-toth is there any status on the Jetty check? It would be good to merge the fix due to the outstanding CVE issue.

@peter-toth
Copy link
Contributor Author

@coheigea , unfortunately I didn't have time to check http mode, but we are using version 9.4.26.v20200117 now.

@coheigea
Copy link

This PR is superceded by #305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants