Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVY-715][DOC] The configuration in the template is inconsistent with LivyConf.scala #261

Closed
wants to merge 1 commit into from

Conversation

captainzmc
Copy link
Member

What changes were proposed in this pull request?

When I test livy impersonation found that, in livy.conf.template the value of livy.impersonation.enabled is true. So I thought impersonation was enabled by default.             
However, impersonation was not turned on when we test. I found that the real configuration in LivyConf. scala is false. 
This can mislead users.

How was this patch tested?

no need

@captainzmc captainzmc changed the title [LIVY-715][DOC]The configuration in the template is inconsistent with LivyConf.scala [LIVY-715][DOC] The configuration in the template is inconsistent with LivyConf.scala Nov 20, 2019
@captainzmc
Copy link
Member Author

@jerryshao Just change the doc to avoid misleading the user. Could please help review it?

@captainzmc captainzmc closed this Nov 21, 2019
@captainzmc captainzmc reopened this Nov 21, 2019
@codecov-io
Copy link

codecov-io commented Nov 21, 2019

Codecov Report

Merging #261 into master will increase coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #261      +/-   ##
============================================
+ Coverage     67.85%   68.19%   +0.34%     
- Complexity      937      941       +4     
============================================
  Files           102      102              
  Lines          5876     5876              
  Branches        891      891              
============================================
+ Hits           3987     4007      +20     
+ Misses         1315     1299      -16     
+ Partials        574      570       -4
Impacted Files Coverage Δ Complexity Δ
...ain/java/org/apache/livy/rsc/driver/RSCDriver.java 80.75% <0%> (+2.09%) 45% <0%> (+2%) ⬆️
...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala 55.88% <0%> (+2.94%) 7% <0%> (ø) ⬇️
rsc/src/main/java/org/apache/livy/rsc/rpc/Rpc.java 82.24% <0%> (+2.95%) 12% <0%> (ø) ⬇️
...in/java/org/apache/livy/rsc/rpc/RpcDispatcher.java 62.24% <0%> (+3.06%) 20% <0%> (+1%) ⬆️
...c/src/main/java/org/apache/livy/rsc/RSCClient.java 77.1% <0%> (+3.61%) 20% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6261c57...148e5dc. Read the comment docs.

@yiheng
Copy link
Contributor

yiheng commented Nov 21, 2019

Yes. This template configuration is conflicted with this code
https://github.com/apache/incubator-livy/blob/master/server/src/main/scala/org/apache/livy/LivyConf.scala#L72

+1

Copy link
Contributor

@jerryshao jerryshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jerryshao jerryshao closed this in 8f1e898 Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants