[LIVY-868] ACL on livy session listing #329
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks if requester is session owner or has rights to view session before returning the session.
zinking
reviewed
Oct 21, 2021
| @@ -72,7 +72,10 @@ abstract class SessionServlet[S <: Session, R <: RecoveryMetadata]( | |||
| val from = params.get("from").map(_.toInt).getOrElse(0) | |||
| val size = params.get("size").map(_.toInt).getOrElse(100) | |||
|
|
|||
| val sessions = sessionManager.all() | |||
| val sessions = sessionManager.all().filter( | |||
There was a problem hiding this comment.
this is incomplete, what about access from /sessionId ?
There was a problem hiding this comment.
@zinking I have update the code and changed the withUnprotectedSession to withViewAccessSession to protect access from /sessionId.
Change withUnprotectedSession to withViewAccessSession for get("/:id") and get("/:id/state") to check if the requester is session owner or has rights to view session before returning the session.
|
Retrigger the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks if requester is session owner or has rights to view session before returning the session.
What changes were proposed in this pull request?
Filter sessions listing (in get('/")) returned by SessionServlet based on ownership and access granted.
https://issues.apache.org/jira/browse/LIVY-868
How was this patch tested?
Changes tested manually in kerberized environment.
Only able to see own sessions in UI page unless view and able permission granted.