[LIVY-416] Upgrade the version of Jackson from 2.4.4 to 2.9.2 #64
Conversation
|
I guess your changes affect the classpath of integration test, which makes all the integration tests fail. |
kjmrknsn
force-pushed
the
LIVY-416
branch
4 times, most recently
from
077703e
to
1ec5bd3
Compare
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
============================================
+ Coverage 70.53% 71.21% +0.67%
- Complexity 800 803 +3
============================================
Files 97 97
Lines 5461 5461
Branches 801 801
============================================
+ Hits 3852 3889 +37
+ Misses 1081 1047 -34
+ Partials 528 525 -3
Continue to review full report at Codecov.
|
|
Travis CI status turned to green: https://travis-ci.org/apache/incubator-livy/builds/305717408 |
|
Can you please explain why adding guava dependency will fix the previous issue? Guava is a transient dependency introduced by Jackson-module, not sure why do we need to add it explicitly? |
It's necessary to add guava to the dependencies explicitly, which is included in the dependencies of jackson-module-scala 2.4.4 because the |
kjmrknsn
force-pushed
the
LIVY-416
branch
3 times, most recently
from
f106064
to
e5f2fa9
Compare
|
LGTM, thanks for explanation. |
|
Travis is not so stable, you need to trigger several times to make it pass. |
Thanks. The status turned to green: https://travis-ci.org/apache/incubator-livy/builds/306139499 |
|
Thanks, let me merge to master. |
|
Because of sync issue between github and apache git, this jira merged in apache (https://git-wip-us.apache.org/repos/asf?p=incubator-livy.git;a=shortlog;h=refs/heads/master) didn't sync to github. It will be fixed automatically by pushing new commits. |
## What changes were proposed in this pull request? https://issues.apache.org/jira/browse/LIVY-416 `com.fasterxml.jackson.core.JsonGenerationException` is sometimes thrown. The full stack trace is show on [JsonGenerationException.txt](https://github.com/apache/incubator-livy/files/1482566/JsonGenerationException.txt). This is because of the Jackson's bug (FasterXML/jackson-core#307) which was fixed at Jackson 2.7.7. To fix this issue, the version of Jackson should be updated from 2.4.4 to the latest one (2.9.2). In addition, `com.google.guava:guava:15.0` was added to the dependencies because it was removed from the dependencies of `com.fasterxml.jackson.module:jackson-module-scala_{2.10,2.11}:2.9.2`. * [com.fasterxml.jackson.module:jackson-module-scala_2.10:2.4.4](https://mvnrepository.com/artifact/com.fasterxml.jackson.module/jackson-module-scala_2.10/2.4.4) * [com.fasterxml.jackson.module:jackson-module-scala_2.11:2.4.4](https://mvnrepository.com/artifact/com.fasterxml.jackson.module/jackson-module-scala_2.11/2.4.4) * [com.fasterxml.jackson.module:jackson-module-scala_2.10:2.9.2](https://mvnrepository.com/artifact/com.fasterxml.jackson.module/jackson-module-scala_2.10/2.9.2) * [com.fasterxml.jackson.module:jackson-module-scala_2.11:2.9.2](https://mvnrepository.com/artifact/com.fasterxml.jackson.module/jackson-module-scala_2.11/2.9.2) ## How was this patch tested? By executing `mvn clean package`. Author: Keiji Yoshida <kjmrknsn@gmail.com> Closes #64 from kjmrknsn/LIVY-416.
|
Thanks for merging. May I close this PR? |
|
Yes, please. |
What changes were proposed in this pull request?
https://issues.apache.org/jira/browse/LIVY-416
com.fasterxml.jackson.core.JsonGenerationExceptionis sometimes thrown. The full stack trace is show on JsonGenerationException.txt.This is because of the Jackson's bug (FasterXML/jackson-core#307) which was fixed at Jackson 2.7.7.
To fix this issue, the version of Jackson should be updated from 2.4.4 to the latest one (2.9.2).
In addition,
com.google.guava:guava:15.0was added to the dependencies because it was removed from the dependencies ofcom.fasterxml.jackson.module:jackson-module-scala_{2.10,2.11}:2.9.2.How was this patch tested?
By executing
mvn clean package.