Skip to content
This repository has been archived by the owner on Mar 9, 2023. It is now read-only.

Changing Dockerfile to use Alpine Linux python images #31

Merged
merged 1 commit into from
Jul 27, 2019
Merged

Changing Dockerfile to use Alpine Linux python images #31

merged 1 commit into from
Jul 27, 2019

Conversation

cardosolucas
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #31 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #31   +/-   ##
========================================
  Coverage    70.92%   70.92%           
========================================
  Files           26       26           
  Lines         2198     2198           
  Branches       226      226           
========================================
  Hits          1559     1559           
  Misses         618      618           
  Partials        21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d9d401...d55a702. Read the comment docs.

Copy link
Member

@Wei-1 Wei-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the only problem is that:
Currently, we are having another PR #27, that is fixing the same file.
I think this PR should have a higher priority.
Any other thought?

@cardosolucas
Copy link
Contributor Author

I think that is OK! I submitted this PR thinking about that discussion you guys had in that PR, and it was also a attempt to make a smaller Docker image.

@Wei-1
Copy link
Member

Wei-1 commented Jul 22, 2019

I will merge the PR this weekend if everyone seems fine with it.

@rafaelnovello
Copy link
Contributor

rafaelnovello commented Jul 22, 2019 via email

@asfgit asfgit merged commit d55a702 into apache:develop Jul 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants