Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Some wrong with mxnet on spark: params.jars = jars.split(",|:") #11093

Closed
liuzx32 opened this issue May 30, 2018 · 7 comments
Closed

Some wrong with mxnet on spark: params.jars = jars.split(",|:") #11093

liuzx32 opened this issue May 30, 2018 · 7 comments

Comments

@liuzx32
Copy link

liuzx32 commented May 30, 2018

The method setExecutorJars in org.apache.mxnet.spark.MXNet.scala has 'params.jars = jars.split(",|:")' sentence. If the jars from s3://path or hdfs://path, there will be wrong jar path, for example s3 or hdfs or others. Perhaps 'params.jars = jars.split(",")' is recommended.

@anirudhacharya
Copy link
Member

anirudhacharya commented May 30, 2018

@nswamy @lanking520 could one of you take a look?

@lanking520
Copy link
Member

@yzhliu @nswamy @@andrewfayres .I think we need to build regex to identify these different formats, will start a PR and try if I can solve that. @nswamy can you label this as Scala and bug in here?

@nswamy nswamy added the Scala label Jun 6, 2018
@yzhliu
Copy link
Member

yzhliu commented Jun 6, 2018

An alternative is to allow users to use quotation mark. string in quotations should never be split: "s3://path":"hdfs://path"

@lanking520
Copy link
Member

Hi @liuzx32 , the jars will be used in this way:

jars.map(jar => SparkFiles.get(new File(jar).getName)).mkString(":")

It seemed we cannot directly place S3 or HDFS paths in here. So It's not necessary to initiate this change.

@nswamy
Copy link
Member

nswamy commented Jun 7, 2018

Not an issue at the moment and We will add a Feature Request to support jars from S3 and HDFS.

@liuzx32
Copy link
Author

liuzx32 commented Jun 13, 2018

@yzhliu @lanking520 Mxnet on spark should be for yarn cluster mode not only yarn local mode. If every machine have the same configure of mxnet, why we need yarn or spark?

@liuzx32
Copy link
Author

liuzx32 commented Jun 13, 2018

@lanking520 Perhaps the problem is here:
jars.map(jar => SparkFiles.get(new File(jar).getName)).mkString(":")
With the sentence how to run on yarn?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants