Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

How can I best add support for complex numbers? #9109

Closed
aodhan-domhnaill opened this issue Dec 17, 2017 · 2 comments
Closed

How can I best add support for complex numbers? #9109

aodhan-domhnaill opened this issue Dec 17, 2017 · 2 comments

Comments

@aodhan-domhnaill
Copy link

MXNet would work great as a framework for Physics simulations. Unfortunately, you don't support complex numbers!!! I would happily add support for this, assuming it isn't going to be incredibly hard.

What would be the most straightforward means of adding Complex number support?

@yzhliu
Copy link
Member

yzhliu commented Apr 11, 2018

I would say it is not easy to add complex number support. basically you need to define how to do + - * / ... for the new type ComplexNumber, and let NDArray aware of ComplexNumber. And what make it more complicated is for operators defined in mshadow, make sure the functions defined by c++ template can handle it. Also for calculation in operators, some codes cast dtype by DType(input) where DType is a template.

@yzhliu
Copy link
Member

yzhliu commented Apr 11, 2018

Close for now and feel free to reopen if you want to discuss more.

@yzhliu yzhliu closed this as completed Apr 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants