Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fixed calling error while preparing data in ssd #10024

Merged
merged 1 commit into from Mar 10, 2018
Merged

fixed calling error while preparing data in ssd #10024

merged 1 commit into from Mar 10, 2018

Conversation

zlin3000
Copy link
Contributor

@zlin3000 zlin3000 commented Mar 7, 2018

fixed calling error while calling im2rec.py in prepare_dataset.py
add threads support in prepare_dataset.py

Description

Since the im2rec.py is changed, the calling method in prepare_dataset.py in ssd is invalid. Thus, modified the code to allow converting data correctly. Also, added threads support to improve converting speed.

Checklist

Essentials

  • Passed code style checking (make lint)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

fixed calling error while calling im2rec.py in prepare_dataset.py
add threads support in prepare_dataset.py
@zlin3000 zlin3000 requested a review from szha as a code owner March 7, 2018 10:46
@piiswrong
Copy link
Contributor

@zhreshold

@zhreshold zhreshold merged commit bf8658b into apache:master Mar 10, 2018
jinhuang415 pushed a commit to jinhuang415/incubator-mxnet that referenced this pull request Mar 30, 2018
fixed calling error while calling im2rec.py in prepare_dataset.py
add threads support in prepare_dataset.py
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
fixed calling error while calling im2rec.py in prepare_dataset.py
add threads support in prepare_dataset.py
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
fixed calling error while calling im2rec.py in prepare_dataset.py
add threads support in prepare_dataset.py
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants