This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
add axes support for dropouts in gluon #10032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxjscience
reviewed
Mar 8, 2018
| @@ -239,15 +241,16 @@ class Dropout(HybridBlock): | |||
| `Dropout: A Simple Way to Prevent Neural Networks from Overfitting | |||
| <http://www.cs.toronto.edu/~rsalakhu/papers/srivastava14a.pdf>`_ | |||
| """ | |||
| def __init__(self, rate, **kwargs): | |||
| def __init__(self, rate, axes=(), **kwargs): | |||
There was a problem hiding this comment.
This is the same default value as the one added in Dropout op. I set it this way so that I don't have to handle None.
sxjscience
reviewed
Mar 8, 2018
| compactshape[axis] = 1 | ||
| compactx = mx.random.uniform(shape=tuple(compactshape)) | ||
| broadcastx = compactx.broadcast_to(shape) | ||
| dropouty = mx.gluon.nn.Dropout(rate=ratio, axes=axes)(broadcastx) |
There was a problem hiding this comment.
May need consider to improve the test in the future. Currently there's no guarantee that the observed dropout ratio matches the given dropout ratio.
sxjscience
approved these changes
Mar 8, 2018
jinhuang415
pushed a commit
to jinhuang415/incubator-mxnet
that referenced
this pull request
Mar 30, 2018
rahul003
pushed a commit
to rahul003/mxnet
that referenced
this pull request
Jun 4, 2018
zheng-da
pushed a commit
to zheng-da/incubator-mxnet
that referenced
this pull request
Jun 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add axes support for dropouts in gluon
Checklist
Essentials
make lint)Changes