Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-101] Fix flaky test_leaky_relu #10422

Merged
merged 1 commit into from
Apr 5, 2018

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Apr 5, 2018

Description

Get rid of flaky behavior of test_leaky_relu mentioned in #10421.

Checklist

Essentials

  • The PR title starts with [MXNET-101]
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Loosen overly strict rtol for test_leaky_relu and test_prelu

Comments

Also changed the code used to compute the reference value for elu case from "exp() - 1" to "expm1()" to match what we use in src/operator/mshadow_op.h.

@haojin2 haojin2 mentioned this pull request Apr 5, 2018
@piiswrong piiswrong merged commit 153dc77 into apache:master Apr 5, 2018
@haojin2 haojin2 deleted the flaky_leaky_relu branch April 5, 2018 19:57
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants