Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix NNPACK header file position error #10525

Merged
merged 2 commits into from
Apr 16, 2018
Merged

Fix NNPACK header file position error #10525

merged 2 commits into from
Apr 16, 2018

Conversation

yjcn
Copy link
Contributor

@yjcn yjcn commented Apr 12, 2018

Description

NNPACK header files's position has changed,So the code also need to be updated.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@marcoabreu
Copy link
Contributor

Am I missing something or how was it possible that it passed compilation?

@piiswrong
Copy link
Contributor

piiswrong commented Apr 12, 2018

I think nnpack should be moved into nn instead.

@marcoabreu nnpack is not tested in the CI. It was added a long time ago and I don't think it was officially supported

@marcoabreu
Copy link
Contributor

Should we enable it?

@piiswrong
Copy link
Contributor

It's likely not working properly. I think there was an issue on updating nnpack support to include latest changes from nnpack upstream. We should do that first.

@marcoabreu
Copy link
Contributor

Would you mind taking care of that?

@piiswrong
Copy link
Contributor

It's a major work item. We'll need to plan it

@dabraude
Copy link
Contributor

I haven't had much spare time to work on it, but I have been looking into it
on PR #9860

@piiswrong
Copy link
Contributor

in any case i'll merge this first since it doesn't do any harm

@piiswrong piiswrong merged commit fb72ee7 into apache:master Apr 16, 2018
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants