Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

handle NDArray slice properly for mkldnn layout #10619

Merged
merged 2 commits into from
Apr 26, 2018

Conversation

ashokei
Copy link
Contributor

@ashokei ashokei commented Apr 19, 2018

Description

when NDArray asnumpy is called for a view of NDArray, and if the original NDArray has mkldnn layout, a crash is seen. Below code snippet reproduces this issue.

ctx = mx.cpu()
net = gluon.nn.HybridSequential()
with net.name_scope():
    net.add(gluon.nn.Conv2D(channels=32, kernel_size=3, activation=None))
net.collect_params().initialize(mx.init.Xavier(magnitude=2.24), ctx=ctx)
x=nd.array(np.ones([32,3,224,224]), ctx)
y=net(x)

# no issue seen for below
#z=y.asnumpy()

# crash seen for below
z=y[0].asnumpy()

print(z[0,0,0])

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@ashokei
Copy link
Contributor Author

ashokei commented Apr 19, 2018

@zheng-da please review, thanks.

@zheng-da
Copy link
Contributor

can you also add the code snippet as a test?

@ashokei
Copy link
Contributor Author

ashokei commented Apr 25, 2018

@zheng-da can you please review and accept PR, unittest is added. please add approver also, thanks.

@ashokei
Copy link
Contributor Author

ashokei commented Apr 26, 2018

@zheng-da @piiswrong can you please merge this if ok, thanks.

@piiswrong piiswrong merged commit f236687 into apache:master Apr 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants