Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-531][Work In Progress] MNIST Examples for Scala new API #11198

Closed
wants to merge 23 commits into from

Conversation

lanking520
Copy link
Member

Description

This PR contains examples written from the new API.
@nswamy @yzhliu @andrewfayres
All examples pushed here are tested locally on my Mac. It lives in the new package called org.apache.mxnet.examples

Checklist

Essentials

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@lanking520 lanking520 requested a review from yzhliu as a code owner June 8, 2018 06:39
@nswamy
Copy link
Member

nswamy commented Jun 12, 2018

@lanking520 please break into one example per PR with testing and documentation included

@lanking520 lanking520 changed the title [MXNET-531][Work In Progress] add Examples for Scala new API [MXNET-531][Work In Progress] MNIST Examples for Scala new API Jun 12, 2018
@lanking520
Copy link
Member Author

@nswamy Done that, this one MNIST specifically

val tempDirPath = System.getProperty("java.io.tmpdir")
val modelDirPath = tempDirPath + File.separator + "mnist/"
logger.info("tempDirPath: %s".format(tempDirPath))
Process("wget https://s3.us-east-2.amazonaws.com/mxnet-scala/scala-example-ci" +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break on windows (I know we don't support it yet) and requires wget. Are there any scala-tools that allow downloading files with features like retry-mechanisms etc?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to avoid using the Process-Method and rather rely on language-specific tools

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lanking520
Copy link
Member Author

Abandon this PR since it includes too much conflict with Master Branch, open one here: #11250

@lanking520 lanking520 closed this Jun 13, 2018
@lanking520 lanking520 deleted the mxnet-example branch June 13, 2018 17:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants