This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-531] MNIST Examples for Scala new API #11250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
lanking520
force-pushed
the
example-mnist
branch
from
e28cf64
to
2cb18a5
Compare
lanking520
changed the title
lanking520
force-pushed
the
example-mnist
branch
2 times, most recently
from
bfd1634
to
9e8e988
Compare
nswamy
reviewed
Jun 29, 2018
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
There was a problem hiding this comment.
I would have liked author tag with original author's name as well as yours here since you are just copying existing files and modifying a few lines, but ASF does not with allow author tags with Apache 2.0 License :(. Lets discuss offline.
lanking520
force-pushed
the
example-mnist
branch
from
e9bc664
to
720610e
Compare
nswamy
approved these changes
Jul 1, 2018
There was a problem hiding this comment.
Thanks @lanking520, small comment to remove commented code in any other PR
| @@ -31,6 +31,7 @@ object TrainMnist { | |||
| def getMlp: Symbol = { | |||
| val data = Symbol.Variable("data") | |||
|
|
|||
| // val fc1 = Symbol.FullyConnected(name = "relu")()(Map("data" -> data, "act_type" -> "relu")) | |||
There was a problem hiding this comment.
no need to keep it commented, you can remove it completely. change it any of your next PRs. I am going to merge it as is instead of removing this line, I don't want the entire CI suite to run for hour.
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
* Modify MNIST training example to use new Symbol APIs. * Add Tests to the MNIST Train example
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains examples written from the new API.
@nswamy @yzhliu @andrewfayres
All examples pushed here are tested locally on my Mac. It lives in the new package called
org.apache.mxnet.examplesChecklist
Essentials