This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[MXNET-617] - Improve Clojure styles with cljfmt tools revise #11537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add lein-cljfmt-check to each project - Add lein-cljfmt-fix to each project
- Run $MXROOT/contrib/clojure-package/lein-cljfmt-fix
- Run $MXNET_ROOT/contrib/clojure-package/examples/lein-cljfmt-fix
marcoabreu
reviewed
Jul 3, 2018
| @@ -0,0 +1,22 @@ | |||
| #!/usr/bin/env sh | |||
There was a problem hiding this comment.
What do you think about moving this script to a bit more top-level directory and then applying it recursively?
There was a problem hiding this comment.
@marcoabreu
I did not think of this, but yes this is a great idea indeed.
- Thanks to @marcoabreu for the suggestion/review
|
@gigasquid |
|
Thanks @agilecreativity for putting this together. I'll take a look later tonight. |
gigasquid
approved these changes
Jul 3, 2018
XinYao1994
pushed a commit
to XinYao1994/incubator-mxnet
that referenced
this pull request
Aug 29, 2018
…#11537) * Remove 'vi ci-test.sh' file * Add the scripts to reformat the style with cljfmt - Add lein-cljfmt-check to each project - Add lein-cljfmt-fix to each project * Add lein-cljfmt to the plugins vector * Add steps to keep style consistent to README.md * Run lein-cljfmt-fix on the main src/test codes - Run $MXROOT/contrib/clojure-package/lein-cljfmt-fix * Run lein cljfmt fix on the example projects - Run $MXNET_ROOT/contrib/clojure-package/examples/lein-cljfmt-fix * Use only one script in the base directory. - Thanks to @marcoabreu for the suggestion/review * Minor update to kick off the new build
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use cljfmt to keep styles of the project consistent.
This include the updated version that have a cleaner commit history and rebase on the latest changes from @gigasquid.
Please help review.
Thanks
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
vi ci-test.shfrom the projectlein-cljfmt-checkto each project and the base directory to be run in batchlein-cljfmt-fixto fix the style of the project excluding some files when necessaryComments
lein-cljfmt-checkis intentionally omit the-eto allow the script to continue