Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix a bug in where op with 1-D input #12325

Merged
merged 2 commits into from Aug 24, 2018
Merged

Fix a bug in where op with 1-D input #12325

merged 2 commits into from Aug 24, 2018

Conversation

apeforest
Copy link
Contributor

@apeforest apeforest commented Aug 24, 2018 •
edited

Description

Fix a bug in shape infer in where operator with 1-D input.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • fix a bug of infershape in where operator with 1-D input
  • added a unit test in test_operator: test_1d_cond()

@apeforest
Copy link
Contributor Author

@zheng-da Please review

@zheng-da
Copy link
Contributor

Please add a test case for 1D arrays

@apeforest
Copy link
Contributor Author

@zheng-da Added unit test and created an issue #12337 for further handling of infershape for all operators in Symbolic mode.

@szha szha merged commit 91730fd into apache:master Aug 24, 2018
Roshrini pushed a commit to Roshrini/mxnet that referenced this pull request Aug 24, 2018
@apeforest @Roshrini
Fix a bug in where op with 1-D input (apache#12325)
396b6c3 
* Fix a bug in where op with 1-D input

* Add unit test
@Roshrini Roshrini mentioned this pull request Aug 24, 2018
Merged
3 tasks
szha pushed a commit that referenced this pull request Aug 24, 2018
@Roshrini @szha
Release1.3 cherry-pick few PRs (#12338)
d343276 
* Fix a bug in where op with 1-D input (#12325)

* Fix a bug in where op with 1-D input

* Add unit test

* [MXNET-849] - Enable armv7 with pinned docker images. (#12272)

* Revert "Temporarily disable ARMv7 builds (#12260)"

This reverts commit a4aced7.

* [MXNET-849] Pin armv7 dockcross image

Co-authored-by: Anton Chernov <mechernov@gmail.com>

* [MXNET-855] Update clang to version 6 (#12305)
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
@apeforest @szha
Fix a bug in where op with 1-D input (apache#12325)
c848d30 
* Fix a bug in where op with 1-D input

* Add unit test
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
@apeforest @anirudh2290
Fix a bug in where op with 1-D input (apache#12325)
4a88bd5 
* Fix a bug in where op with 1-D input

* Add unit test
@apeforest apeforest deleted the bugfix/infer-shape branch January 7, 2020 22:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zheng-da zheng-da zheng-da approved these changes

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apeforest @zheng-da @szha