Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-849] - Enable armv7 with pinned docker images. #12272

Merged
merged 2 commits into from
Aug 23, 2018
Merged

[MXNET-849] - Enable armv7 with pinned docker images. #12272

merged 2 commits into from
Aug 23, 2018

Conversation

KellenSunderland
Copy link
Contributor

Description

Re-enable ARMv7 builds using pinned dockcross images.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

lebeg
lebeg approved these changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@lebeg lebeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@KellenSunderland KellenSunderland changed the title [MXNET-849] - Enable armv7 pinned [MXNET-849] - Enable armv7 with pinned docker images. Aug 21, 2018
@KellenSunderland
Copy link
Contributor Author

KellenSunderland commented Aug 21, 2018 •
edited
Loading

@marcoabreu This should address armv7 issues, but let's test this well before merging. Id propose we do a few builds.

@KellenSunderland KellenSunderland changed the title [MXNET-849] - Enable armv7 with pinned docker images. WIP - [MXNET-849] - Enable armv7 with pinned docker images. Aug 21, 2018
@lebeg lebeg mentioned this pull request Aug 21, 2018
Merged
5 tasks
@marcoabreu
Copy link
Contributor

Please rebase since i've just merged the other PR.

KellenSunderland and others added 2 commits August 21, 2018 15:59
@KellenSunderland
Revert "Temporarily disable ARMv7 builds (apache#12260)"
4b5fbf0 
This reverts commit a4aced7.
@KellenSunderland @lebeg
[MXNET-849] Pin armv7 dockcross image
b1894d3 
Co-authored-by: Anton Chernov <mechernov@gmail.com>
@KellenSunderland
Copy link
Contributor Author

Rebased.

@KellenSunderland
Copy link
Contributor Author

Triggering once more, then I'm comfortable with merging.

@KellenSunderland KellenSunderland changed the title WIP - [MXNET-849] - Enable armv7 with pinned docker images. [MXNET-849] - Enable armv7 with pinned docker images. Aug 21, 2018
@marcoabreu marcoabreu merged commit e1b2265 into apache:master Aug 23, 2018
Roshrini pushed a commit to Roshrini/mxnet that referenced this pull request Aug 24, 2018
@KellenSunderland @lebeg @Roshrini
[MXNET-849] - Enable armv7 with pinned docker images. (apache#12272)
2173b3a 
* Revert "Temporarily disable ARMv7 builds (apache#12260)"

This reverts commit a4aced7.

* [MXNET-849] Pin armv7 dockcross image

Co-authored-by: Anton Chernov <mechernov@gmail.com>
@Roshrini Roshrini mentioned this pull request Aug 24, 2018
Merged
3 tasks
szha pushed a commit that referenced this pull request Aug 24, 2018
@Roshrini @szha
Release1.3 cherry-pick few PRs (#12338)
d343276 
* Fix a bug in where op with 1-D input (#12325)

* Fix a bug in where op with 1-D input

* Add unit test

* [MXNET-849] - Enable armv7 with pinned docker images. (#12272)

* Revert "Temporarily disable ARMv7 builds (#12260)"

This reverts commit a4aced7.

* [MXNET-849] Pin armv7 dockcross image

Co-authored-by: Anton Chernov <mechernov@gmail.com>

* [MXNET-855] Update clang to version 6 (#12305)
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
@KellenSunderland @lebeg @marcoabreu
[MXNET-849] - Enable armv7 with pinned docker images. (apache#12272)
7d9febd 
* Revert "Temporarily disable ARMv7 builds (apache#12260)"

This reverts commit a4aced7.

* [MXNET-849] Pin armv7 dockcross image

Co-authored-by: Anton Chernov <mechernov@gmail.com>
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
@KellenSunderland @lebeg @anirudh2290
[MXNET-849] - Enable armv7 with pinned docker images. (apache#12272)
67f7348 
* Revert "Temporarily disable ARMv7 builds (apache#12260)"

This reverts commit a4aced7.

* [MXNET-849] Pin armv7 dockcross image

Co-authored-by: Anton Chernov <mechernov@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcoabreu marcoabreu marcoabreu approved these changes

@lebeg lebeg lebeg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KellenSunderland @marcoabreu @lebeg