Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

MXNET-858 Add Codecov report for Clojure Package #12335

Merged
merged 1 commit into from Aug 25, 2018

Conversation

gigasquid
Copy link
Member

@gigasquid gigasquid commented Aug 24, 2018

Description

Add Code coverage report for the Clojure Package

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Modify the ci-test script to add running the clojure coverage tool. This will output a report in the target directory that is picked up by the codecov script.

Note that the report does not need to be put in the top level project directory. The codecov.io script will recurse and find the report in /contrib/clojure-package/target/

Result of running from my local machine ./contrib/clojure-pacakge/ci-test.sh:

Writing HTML report to: /Users/cmeier/workspace/deep-learning/mxnet/contrib/clojure-package/target/coverage/index.html
Writing codecov.io report to: /Users/cmeier/workspace/deep-learning/mxnet/contrib/clojure-package/target/coverage/codecov.json

Result of running curl --retry 10 -s https://codecov.io/bash | bash -s from the mxnet root directory on my local machine:


  _____          _
 / ____|        | |
| |     ___   __| | ___  ___ _____   __
| |    / _ \ / _` |/ _ \/ __/ _ \ \ / /
| |___| (_) | (_| |  __/ (_| (_) \ V /
 \_____\___/ \__,_|\___|\___\___/ \_/
                              Bash-0b37652


x> No CI provider detected.
    Testing inside Docker? http://docs.codecov.io/docs/testing-with-docker
    Testing with Tox? https://docs.codecov.io/docs/python#section-testing-with-tox
    project root: .
    Yaml found at: .codecov.yml
==> Running gcov in . (disable via -X gcov)
==> Python coveragepy not found
==> Searching for coverage reports in:
    + .
    -> Found 1 reports
==> Detecting git/mercurial file structure
==> Reading reports
    + ./contrib/clojure-package/target/coverage/codecov.json bytes=16866
==> Appending adjustments
    http://docs.codecov.io/docs/fixing-reports
    + Found adjustments
==> Gzipping contents
==> Uploading reports

@gigasquid gigasquid added Clojure pr-awaiting-review PR is waiting for code review labels Aug 24, 2018
@marcoabreu
Copy link
Contributor

AWESOME! Thanks a lot!

Just to confirm. Are we using our test publish results method that's in the runtime functions or is clojure using its own method to publish here? It's important that we use our own method

@marcoabreu marcoabreu added pr-awaiting-response PR is reviewed and waiting for contributor to respond and removed pr-awaiting-review PR is waiting for code review labels Aug 24, 2018
@marcoabreu
Copy link
Contributor

Nevermind, just found out it uses or method. Great!

Waiting for confirmation from CI that it's properly picking up the report. Then we are good to go

@marcoabreu marcoabreu added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-response PR is reviewed and waiting for contributor to respond labels Aug 24, 2018
@marcoabreu marcoabreu merged commit 39d0d06 into apache:master Aug 25, 2018
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request Sep 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Clojure pr-awaiting-testing PR is reviewed and waiting CI build and test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants