Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix document for take operator #13947

Merged
merged 2 commits into from
Jan 21, 2019
Merged

Fix document for take operator #13947

merged 2 commits into from
Jan 21, 2019

Conversation

TaoLv
Copy link
Member

@TaoLv TaoLv commented Jan 21, 2019

Description

>>> import mxnet as mx
>>> x=mx.nd.array([[1,2], [3,4], [5,6]])
>>> x

[[ 1.  2.]
 [ 3.  4.]
 [ 5.  6.]]
<NDArray 3x2 @cpu(0)>
>>> idx=mx.nd.array([[0,1],[1,2]])
>>> idx

[[ 0.  1.]
 [ 1.  2.]]
<NDArray 2x2 @cpu(0)>
>>> mx.nd.take(x,idx)

[[[ 1.  2.]
  [ 3.  4.]]

 [[ 3.  4.]
  [ 5.  6.]]]
<NDArray 2x2x2 @cpu(0)>
>>>
>>>
>>> idx=mx.nd.array([[0,3],[-1,-2]])
>>>
>>> mx.nd.take(x,idx, axis=1, mode='wrap')

[[[ 1.  2.]
  [ 2.  1.]]

 [[ 3.  4.]
  [ 4.  3.]]

 [[ 5.  6.]
  [ 6.  5.]]]
<NDArray 3x2x2 @cpu(0)>

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@marcoabreu marcoabreu merged commit 3165262 into apache:master Jan 21, 2019
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Jan 27, 2019
stephenrawls pushed a commit to stephenrawls/incubator-mxnet that referenced this pull request Feb 16, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants