This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[v1.4.x] Add MXEnginePushAsync and MXEnginePushSync C APIs (#14615) #14770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add PushAsyncPtr and PushSyncPtr APIs in engine * avoid using shared_ptr for param in new APIs * avoid using std::vector in parameters * change to C API * address comments and add tests * fix perl build * use int instead of size_t
yuxihu
changed the title
|
@junrushao1994 @szha @eric-haibin-lin @apeforest Please help review and merge. Thanks. |
|
Is this going into the pip package? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick the change that fixes GCC incompatibility issue for running MXNet with Horovod to v1.4.x branch.