Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Re-enable flaky test_prelu #15777

Merged
merged 1 commit into from
Aug 19, 2019
Merged

Re-enable flaky test_prelu #15777

merged 1 commit into from
Aug 19, 2019

Conversation

larroy
Copy link
Contributor

@larroy larroy commented Aug 7, 2019

Description

Re-enables disabled flaky test_prelu

Fixes #12885

run flakyness checker without issue:

python tools/flakiness_checker.py -v 10 tests/python/unittest/test_operator.py:test_prelu

@larroy
Copy link
Contributor Author

larroy commented Aug 8, 2019

@mxnet-label-bot add [Flaky,Test]

@wkcn
Copy link
Member

wkcn commented Aug 11, 2019

It's flaky why the test is passed now?

@larroy
Copy link
Contributor Author

larroy commented Aug 12, 2019

I run many times and it didn't fail with the flakyness checker. Maybe there was a change that affected it not to be flaky anymore?

Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you! : )

@wkcn wkcn added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Aug 18, 2019
@wkcn wkcn merged commit bcbdc1c into apache:master Aug 19, 2019
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Flaky pr-awaiting-merge Review and CI is complete. Ready to Merge Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_prelu fails frequently.
3 participants