Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Numpy Tensordot and Dot Operator #15820

Merged
merged 5 commits into from Aug 12, 2019
Merged

Conversation

ckt624
Copy link
Contributor

@ckt624 ckt624 commented Aug 9, 2019

Description

Implements numpy tensordot operator. See
https://docs.scipy.org/doc/numpy/reference/generated/numpy.tensordot.html
Also implement the numpy dot of tensors by using tensordot. See
https://docs.scipy.org/doc/numpy/reference/generated/numpy.dot.html

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Implements tensordot and tests
  • Implements dot and tests

Comments

@haojin2 @reminisce

@ckt624 ckt624 requested a review from szha as a code owner August 9, 2019 07:37
@yzhliu yzhliu added the Numpy label Aug 9, 2019
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haojin2 haojin2 merged commit c3f5eea into apache:master Aug 12, 2019
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
* Implements tensordot and dot.

* Change tests.

* Add spaces.

* Reorganize codes.

* Remove np_matrix_op.h
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants