Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] Trace #16008

Merged
merged 1 commit into from
Sep 22, 2019
Merged

[Numpy] Trace #16008

merged 1 commit into from
Sep 22, 2019

Conversation

hzfan
Copy link
Contributor

@hzfan hzfan commented Aug 26, 2019

Description

Numpy-compatible version of trace with a new kernel

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • numpy-compatible trace operator on CPU and GPU
  • unit tests on CPU and GPU

Comments

Migrate from numpy branch.

Thank @haojin2 @reminisce for guidance and review.

@hzfan hzfan requested a review from szha as a code owner August 26, 2019 08:13
@anirudhacharya
Copy link
Member

@mxnet-label-bot add [pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Aug 26, 2019
@hzfan
Copy link
Contributor Author

hzfan commented Aug 26, 2019

@mxnet-label-bot add [Numpy]

haojin2
haojin2 reviewed Aug 27, 2019
View reviewed changes
python/mxnet/_numpy_op_doc.py Outdated


def _np_trace(a, offset=0, axis1=0, axis2=1, out=None):
"""trace(a, offset=0, axis1=0, axis2=1, out=None)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the indentation

haojin2
haojin2 reviewed Sep 2, 2019
View reviewed changes
src/operator/numpy/np_trace_op.cc

NNVM_REGISTER_OP(_np_trace)
.describe(R"code(Computes the sum of the diagonal elements of a matrix.
Input is a tensor *A* of dimension *n >= 2*.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description section could be skipped.

@reminisce
add numpy compatible trace
0d0a945 
add doc for trace
@reminisce reminisce merged commit da6e744 into apache:master Sep 22, 2019
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Sep 26, 2019
@hzfan @drivanov
add numpy compatible trace (apache#16008)
046edd4 
add doc for trace
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
@hzfan @larroy
add numpy compatible trace (apache#16008)
72230ef 
add doc for trace
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@haojin2 haojin2 haojin2 left review comments

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
Numpy pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hzfan @anirudhacharya @haojin2 @reminisce @marcoabreu