Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

changing data type of 't' to int in lamb_update_phase1 #16903

Merged
merged 2 commits into from
Dec 7, 2019

Conversation

access2rohit
Copy link
Contributor

Description

Fixing data type of t in lamb_update_phase1

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@access2rohit
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-review]

@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Nov 25, 2019
@access2rohit
Copy link
Contributor Author

@sxjscience @eric-haibin-lin PR is ready for review

@eric-haibin-lin eric-haibin-lin merged commit ca4939f into apache:master Dec 7, 2019
ptrendx pushed a commit to ptrendx/mxnet that referenced this pull request Dec 10, 2019
…6903)

* changing data type of 't' to int in lamb_update_phase1

* taking operation beta^t out of kernel call
eric-haibin-lin pushed a commit that referenced this pull request Dec 10, 2019
* changing data type of 't' to int in lamb_update_phase1

* taking operation beta^t out of kernel call
eric-haibin-lin pushed a commit to eric-haibin-lin/mxnet that referenced this pull request Dec 14, 2019
…6903)

* changing data type of 't' to int in lamb_update_phase1

* taking operation beta^t out of kernel call
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants