Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] FFI for linalg ops #17795

Merged
merged 1 commit into from
Apr 7, 2020
Merged

[Numpy] FFI for linalg ops #17795

merged 1 commit into from
Apr 7, 2020

Conversation

sjtuWangDing
Copy link
Contributor

Description

FFI for linalg inv/pinv/eigvals/eigvalsh/solve/tensorsolve/tensorinv/cholesky

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@sjtuWangDing sjtuWangDing requested a review from szha as a code owner March 9, 2020 17:40
@reminisce reminisce added the Numpy label Mar 9, 2020
@sjtuWangDing sjtuWangDing force-pushed the FFI_linalg_op branch 5 times, most recently from 99c998d to 2206d8b Compare March 12, 2020 17:00
hzfan
hzfan reviewed Mar 13, 2020
View reviewed changes
src/api/operator/numpy/linalg/np_eigvals.cc Outdated Show resolved Hide resolved
src/api/operator/numpy/linalg/np_pinv.cc Outdated Show resolved Hide resolved
src/api/operator/numpy/linalg/np_pinv.cc Outdated Show resolved Hide resolved
src/api/operator/numpy/linalg/np_potrf.cc Outdated Show resolved Hide resolved
src/api/operator/numpy/linalg/np_tensorinv.cc Outdated Show resolved Hide resolved
src/api/operator/numpy/linalg/np_tensorsolve.cc Outdated Show resolved Hide resolved
python/mxnet/numpy/linalg.py Outdated Show resolved Hide resolved
@sjtuWangDing sjtuWangDing force-pushed the FFI_linalg_op branch 6 times, most recently from a40e541 to 54f5971 Compare March 15, 2020 17:03
@apeforest apeforest mentioned this pull request Mar 15, 2020
Open
@sjtuWangDing sjtuWangDing force-pushed the FFI_linalg_op branch 5 times, most recently from cbd78a4 to 6e420c3 Compare March 24, 2020 06:20
@hzfan
Copy link
Contributor

hzfan commented Mar 25, 2020

@mxnet-bot run ci [centos-cpu, windows-gpu]

@mxnet-bot
Copy link

Unauthorized access detected.
Only following 3 categories can trigger CI :
PR Author, MXNet Committer, Jenkins Admin.

@sjtuWangDing
Copy link
Contributor Author

@mxnet-bot run ci [centos-cpu, windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu, centos-cpu]

@sjtuWangDing
Copy link
Contributor Author

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@leezu
Copy link
Contributor

leezu commented Mar 25, 2020

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@leezu leezu mentioned this pull request Mar 25, 2020
Closed
@sjtuWangDing
Copy link
Contributor Author

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

* impl - FFi for linalg op
c767ebb 
* fix - cpplint

* impl - benchmark ffi for ops

* rm - FFI for ops with param

* fix - makefile

* fix - not include unordered_map and use num_inputs

* ci - compiler error

* fix - change cholesky interface
@yzhliu yzhliu merged commit 002d4f1 into apache:master Apr 7, 2020
@yzhliu
Copy link
Member

yzhliu commented Apr 7, 2020

Thanks @sjtuWangDing @hzfan

mk-61 pushed a commit to mk-61/incubator-mxnet that referenced this pull request Apr 7, 2020
@sjtuWangDing
* impl - FFi for linalg op (apache#17795)
bc1decd 
* fix - cpplint

* impl - benchmark ffi for ops

* rm - FFI for ops with param

* fix - makefile

* fix - not include unordered_map and use num_inputs

* ci - compiler error

* fix - change cholesky interface

Co-authored-by: Ubuntu <ubuntu@ip-172-31-10-214.us-east-2.compute.internal>
sxjscience pushed a commit to sxjscience/mxnet that referenced this pull request Jul 1, 2020
@sjtuWangDing @sxjscience
* impl - FFi for linalg op (apache#17795)
fd17146 
* fix - cpplint

* impl - benchmark ffi for ops

* rm - FFI for ops with param

* fix - makefile

* fix - not include unordered_map and use num_inputs

* ci - compiler error

* fix - change cholesky interface

Co-authored-by: Ubuntu <ubuntu@ip-172-31-10-214.us-east-2.compute.internal>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hzfan hzfan hzfan left review comments

@yzhliu yzhliu yzhliu approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
Numpy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sjtuWangDing @hzfan @mxnet-bot @leezu @yzhliu @reminisce