Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MYRIAD-304 Keep a config file (checkstyle, findbugs) for all submodules #135

Merged
merged 1 commit into from Aug 5, 2019

Conversation

oscarfmdc
Copy link
Member

No description provided.

@javiroman javiroman self-requested a review August 5, 2019 12:24
Copy link
Member

@javiroman javiroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in fresh environment. It works fine:

Task :myriad-scheduler:checkstyleMain
[ant:checkstyle] [ERROR] /home/vagrant/incubator-myriad/myriad-scheduler/src/main/java/org/apache/myriad/Main.java:91: TODO is preferred to FIXME.  e.g. "TODO (johndoe): Refactor when v2 is released." [RegexpSingleline]
 Task :myriad-scheduler:checkstyleMain FAILED

FAILURE: Build failed with an exception.

@oscarfmdc oscarfmdc merged commit 6d79897 into apache:master Aug 5, 2019
@oscarfmdc oscarfmdc deleted the MYRIAD-304 branch August 6, 2019 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants