[NEMO-252] Fix CreatViewTransform to emit windowed materialized data #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create view create view fix final
johnyangk
suggested changes
Nov 2, 2018
| private final MultiView<Object> multiView; | ||
| private final Map<BoundedWindow, List<I>> windowListMap; | ||
|
|
||
| // TODO #XXX: we should remove this variable by refactoring broadcast worker for side input |
There was a problem hiding this comment.
Please create a JIRA issue.
| iterator.remove(); | ||
| isEmitted = true; | ||
|
|
||
| if (outputTimestamp > entry.getKey().maxTimestamp().getMillis()) { |
There was a problem hiding this comment.
outputTimeStamp = Math.max(outputTimeStamp, entry.getKey().maxTimestamp().getMillis()) ?
| } | ||
|
|
||
| final Iterator<Map.Entry<BoundedWindow, List<I>>> iterator = windowListMap.entrySet().iterator(); | ||
| long outputTimestamp = Long.MAX_VALUE; |
There was a problem hiding this comment.
maxOutputTimeStampOfEmittedWindows?
|
|
||
| // TODO #XXX: we should remove this variable by refactoring broadcast worker for side input | ||
| private boolean isEmitted = false; | ||
| private long outputWatermark; |
There was a problem hiding this comment.
I will change it to currentOutputWatermark
| final Instant processingTime, | ||
| final Instant synchronizedTime) { | ||
| keyToValues.forEach((key, val) -> { | ||
| long outputTimestamp = Long.MAX_VALUE; |
There was a problem hiding this comment.
maxOutputTimeStampOfEmittedWindows?
|
|
||
| for (final Map.Entry<K, List<WindowedValue<InputT>>> entry : keyToValues.entrySet()) { | ||
| final K key = entry.getKey(); | ||
| final List<WindowedValue<InputT>> val = entry.getValue(); |
| final CreateViewTransform<String, Integer> viewTransform = | ||
| new CreateViewTransform(new SumViewFn()); | ||
|
|
||
| final Instant ts1 = new Instant(1); |
There was a problem hiding this comment.
Share code with GroupByKeyAndWindowDoFnTransformTest?
|
|
||
| @Override | ||
| public Materialization<Materializations.MultimapView<Void, String>> getMaterialization() { | ||
| return null; |
There was a problem hiding this comment.
throw new UnSupportedOperation?
.../src/test/java/org/apache/nemo/compiler/frontend/beam/transform/CreateViewTransformTest.java
Show resolved
Hide resolved
.../src/test/java/org/apache/nemo/compiler/frontend/beam/transform/CreateViewTransformTest.java
Show resolved
Hide resolved
taegeonum
commented
Nov 2, 2018
There was a problem hiding this comment.
@johnyangk Thanks for the review! I've addressed your comments
| private final MultiView<Object> multiView; | ||
| private final Map<BoundedWindow, List<I>> windowListMap; | ||
|
|
||
| // TODO #XXX: we should remove this variable by refactoring broadcast worker for side input |
|
|
||
| // TODO #XXX: we should remove this variable by refactoring broadcast worker for side input | ||
| private boolean isEmitted = false; | ||
| private long outputWatermark; |
There was a problem hiding this comment.
I will change it to currentOutputWatermark
johnyangk
previously approved these changes
Nov 2, 2018
johnyangk
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: NEMO-252: Fix CreatViewTransform to emit windowed materialized data
Major changes:
CreateViewTransformto collect windowed data and emit them by applying a view functionMinor changes
GroupByKeyAndWindowDoFnTransformTests for the changes:
CreateViewTransformTestthat tests materialized data in windows