Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEMO-375] Add option to turn off metric collection to DB #211

Merged
merged 2 commits into from Apr 5, 2019

Conversation

wonook
Copy link
Member

@wonook wonook commented Apr 5, 2019

JIRA: NEMO-375: Add option to turn off metric collection to DB

Major changes:

  • Adds configuration for the DB to turn off metric collection to DB by default.
  • Adds proper README docs

Minor changes to note:

  • None

Tests for the changes:

  • None

Other comments:

  • None

Closes #211

@wonook wonook self-assigned this Apr 5, 2019
@wynot12 wynot12 self-requested a review April 5, 2019 14:21
Copy link
Member

@wynot12 wynot12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wynot12 wynot12 merged commit 6eea2aa into apache:master Apr 5, 2019
@wynot12 wynot12 deleted the 374-turnOffMetrics branch April 5, 2019 14:56
wynot12 pushed a commit that referenced this pull request Sep 24, 2019
JIRA: [NEMO-375: Add option to turn off metric collection to DB](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-375)

**Major changes:**
- None

**Minor changes to note:**
- Removes the static actions that happen nevertheless of the configuration and misleads users

**Tests for the changes:**
- None

**Other comments:**
- None

Closes #224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants