Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEMO-429] SWPP TEAM20 Code Smell Fix #256

Closed
wants to merge 14 commits into from
Closed

[NEMO-429] SWPP TEAM20 Code Smell Fix #256

wants to merge 14 commits into from

Conversation

nevivurn
Copy link

@nevivurn nevivurn commented Dec 2, 2019

JIRA: NEMO-429: TEAM20

Major changes:

  • Fixed code smells (SWPP Code Smell session)

Minor changes to note:

  • As TA suggested, we excluded make transient or serializable error with @java.lang.SuppressWarnings("squid:S00112")

@nevivurn nevivurn changed the title Insights [NEMO-429] SWPP TEAM20 Code Smell Fix [NEMO-429] SWPP TEAM20 Code Smell Fix Dec 2, 2019
@jeongyooneo
Copy link
Contributor

As original repository is removed, I'll reopen PR with the fixed code smells.

@jeongyooneo jeongyooneo closed this Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeongyooneo jeongyooneo Awaiting requested review from jeongyooneo

Assignees

@jeongyooneo jeongyooneo

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@nevivurn @jeongyooneo @nungnung @coffeetea99 @kooyunmo