[NEMO-429] SWPP TEAM 9 code smell fix #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wynot12
reviewed
Dec 6, 2019
wynot12
reviewed
Dec 6, 2019
wynot12
reviewed
Dec 6, 2019
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/BlockManagerWorker.java
Outdated
Show resolved
Hide resolved
wynot12
reviewed
Dec 6, 2019
runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/BlockManagerWorker.java
Outdated
Show resolved
Hide resolved
wynot12
requested changes
Dec 6, 2019
There was a problem hiding this comment.
Thanks for your work team9 :)
But the code has several errors and needs some improvements.
Please check my comments and resolve them.
One thing I want you to ask for is that you should run mvn clean install -DskipTests and make sure there are at least no compile errors.
wynot12
approved these changes
Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: NEMO-429: SWPP TEAM 9 code smell fix
Major changes: