[NEMO-429] SWPP TEAM1 Code Smell Fix #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambda to reference
Team 1, Daeeun Kim
Fix stream transient code smell
taegeonum
requested changes
Dec 3, 2019
There was a problem hiding this comment.
Thanks for the PR!! but it looks like you missed some issues in https://sonarcloud.io/project/issues?fileUuids=AWkltI3qgtFwgfOLu2Ep%2CAWkltI3rgtFwgfOLu2It&id=org.apache.nemo%3Anemo-project&resolved=false&rules=squid%3AS1192%2Csquid%3AS1602%2Csquid%3AS1612
(Remove useless curly braces around statement in Util.java)
Could you please fix the issues and update this PR?
| @@ -59,6 +59,7 @@ public String toString() { | |||
| private final class NemoEventDecoder implements DecoderFactory.Decoder { | |||
|
|
|||
| private final Decoder valueDecoder; | |||
| //NOSONAR | |||
| @@ -58,6 +58,7 @@ public String toString() { | |||
| */ | |||
| private final class NemoEventEncoder<T> implements EncoderFactory.Encoder<T> { | |||
| private final EncoderFactory.Encoder<T> valueEncoder; | |||
| //NOSONAR | |||
remove useless curly braces
Revert "Fix stream transient code smell"
|
done |
taegeonum
approved these changes
Dec 15, 2019
|
LGTM. I'm going to merge it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: NEMO-429: Dec 2nd, 2019 Code session
Major changes:
Fixed code smells