Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEMO-429] SWPP TEAM19 Code Smell Fix #269

Merged
merged 13 commits into from Dec 17, 2019
Merged

[NEMO-429] SWPP TEAM19 Code Smell Fix #269

merged 13 commits into from Dec 17, 2019

Conversation

ulgal
Copy link
Contributor

@ulgal ulgal commented Dec 2, 2019

JIRA: NEMO-429: TEAM19

Major changes:

  • Fixed code smells (SWPP Code Smell session)

Minor changes to note:

  • As TA suggested, we add TODO #430: Pair elements should be serializable at Pair.java

wonook
wonook approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@wonook wonook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I've checked and confirmed that all changes are appropriate and that the test has succeeded. You're all good to go 👍

@wonook wonook merged commit c8a1199 into apache:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonook wonook wonook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@ulgal @wonook @sungbin92 @desiderare @lightb0x