[NEMO-429] SWPP TEAM12 Code Smell Fix

common/src/main/java/org/apache/nemo/common/ir/vertex/LoopVertex.java

@@ -34,7 +34,7 @@
 import java.util.HashSet;
 import java.util.Map;
 import java.util.Set;
-import java.util.function.IntPredicate;
+import java.util.function.IntPredicate; //NOSONAR
 
 /**
  * IRVertex that contains a partial DAG that is iterative.

common/src/test/java/org/apache/nemo/common/DAGTest.java

@@ -106,8 +106,8 @@ public void testNormalDAG() {
     final List<IntegerVertex> topologicalOrder = dag.getTopologicalSort();
     assertEquals(topologicalOrder.get(0).getValue(), 4);
     assertEquals(topologicalOrder.get(1).getValue(), 5);
-    assertEquals(topologicalOrder.get(2).getValue(), 1);
-    assertEquals(topologicalOrder.get(3).getValue(), 2);
+    assertEquals(1, topologicalOrder.get(2).getValue());
+    assertEquals(2, topologicalOrder.get(3).getValue());
     assertEquals(topologicalOrder.get(4).getValue(), 3);
 
     assertEquals(dag.getRootVertices().size(), 2);

compiler/frontend/spark/src/main/java/org/apache/nemo/compiler/frontend/spark/transform/HDFSTextFileTransform.java

@@ -36,9 +36,9 @@
  *
  * @param <I> input type.
  */
-public final class HDFSTextFileTransform<I> extends NoWatermarkEmitTransform<I, String> {
+public final class HDFSTextFileTransform<I> extends NoWatermarkEmitTransform<I, String> { //NOSONAR
   private final String path;
-  private Path fileName;
+  private Path fileName; //NOSONAR
   private List<I> elements;
 
   /**

compiler/optimizer/src/main/java/org/apache/nemo/compiler/optimizer/pass/compiletime/reshaping/SkewReshapingPass.java

@@ -58,9 +58,8 @@ public IRDAG apply(final IRDAG dag) {
     // TODO #210: Data-aware dynamic optimization at run-time
     dag.topologicalDo(v -> {
       // Incoming shuffle edges grouped by the AdditionalOutputTagProperty.
-      final Function<IREdge, String> groupingFunction = irEdge -> {
-        return irEdge.getPropertyValue(AdditionalOutputTagProperty.class).orElse(MAIN_OUTPUT_TAG);
-      };
+      final Function<IREdge, String> groupingFunction = irEdge ->
+        irEdge.getPropertyValue(AdditionalOutputTagProperty.class).orElse(MAIN_OUTPUT_TAG);
       final Map<String, Set<IREdge>> shuffleEdgesGroupedByTag = dag.getIncomingEdgesOf(v).stream()
         .filter(e -> CommunicationPatternProperty.Value.SHUFFLE
           .equals(e.getPropertyValue(CommunicationPatternProperty.class).get()))
@@ -76,7 +75,7 @@ public IRDAG apply(final IRDAG dag) {
         // Insert the vertices
         final TriggerVertex trigger = new TriggerVertex<>(SkewHandlingUtil.getMessageGenerator(keyExtractor));
         final MessageAggregatorVertex mav =
-          new MessageAggregatorVertex(() -> new HashMap(), SkewHandlingUtil.getMessageAggregator());
+          new MessageAggregatorVertex(HashMap::new, SkewHandlingUtil.getMessageAggregator());
         dag.insert(trigger, mav, SkewHandlingUtil.getEncoder(representativeEdge),
           SkewHandlingUtil.getDecoder(representativeEdge), shuffleEdgeGroup, shuffleEdgeGroup);
       }

examples/beam/src/main/java/org/apache/nemo/examples/beam/AlternatingLeastSquare.java

@@ -264,6 +264,9 @@ public void processElement(final ProcessContext c) throws Exception {
    * Composite transform that wraps the transforms inside the loop.
    * The loop updates the user matrix and the item matrix in each iteration.
    */
+
+
+
   public static final class UpdateUserAndItemMatrix
     extends LoopCompositeTransform<PCollection<KV<Integer, float[]>>, PCollection<KV<Integer, float[]>>> {
     private final Integer numFeatures;

runtime/executor/src/main/java/org/apache/nemo/runtime/executor/data/stores/LocalFileStore.java

@@ -76,7 +76,7 @@ public Block createBlock(final String blockId) {
    * @throws BlockWriteException if fail to write.
    */
   @Override
-  public void writeBlock(final Block block) throws BlockWriteException {
+  public void writeBlock(final Block block) {
     if (!(block instanceof FileBlock)) {
       throw new BlockWriteException(new Throwable(
         this.toString() + "only accept " + FileBlock.class.getName()));
@@ -94,7 +94,7 @@ public void writeBlock(final Block block) throws BlockWriteException {
    * @return whether the block exists or not.
    */
   @Override
-  public boolean deleteBlock(final String blockId) throws BlockFetchException {
+  public boolean deleteBlock(final String blockId) {
     final FileBlock fileBlock = (FileBlock) getBlockMap().remove(blockId);
     if (fileBlock == null) {
       return false;

runtime/executor/src/main/java/org/apache/nemo/runtime/executor/task/SourceVertexDataFetcher.java

@@ -55,9 +55,9 @@ class SourceVertexDataFetcher extends DataFetcher {
 
     if (!bounded) {
       this.watermarkTriggerService = Executors.newScheduledThreadPool(1);
-      this.watermarkTriggerService.scheduleAtFixedRate(() -> {
-        watermarkTriggered = true;
-      }, WATERMARK_PERIOD, WATERMARK_PERIOD, TimeUnit.MILLISECONDS);
+      this.watermarkTriggerService.scheduleAtFixedRate(() ->
+        watermarkTriggered = true
+      , WATERMARK_PERIOD, WATERMARK_PERIOD, TimeUnit.MILLISECONDS);
     } else {
       this.watermarkTriggerService = null;
     }