[NEMO-429] SWPP TEAM11 Code Smell Fix #276
Conversation
| @@ -105,7 +105,7 @@ public void testNormalDAG() { | |||
|
|
|||
| final List<IntegerVertex> topologicalOrder = dag.getTopologicalSort(); | |||
| assertEquals(topologicalOrder.get(0).getValue(), 4); | |||
There was a problem hiding this comment.
I believe that this was also the line that you were meant to change. Please check and confirm! Thanks :)
There was a problem hiding this comment.
| @@ -139,9 +139,9 @@ private void fetchDataLazily() { | |||
| LOG.error(exception.getMessage()); | |||
| throw new RuntimeException(exception); | |||
| } | |||
| }); | |||
| }) | |||
There was a problem hiding this comment.
Could you merge the lines 142-144 together, so that it becomes something like }))); ?
Other code follow the convention, so it would be better to keep it that way. Thanks!
| @@ -710,7 +710,7 @@ public IREdge getEdgeById(final String id) { | |||
|
|
|||
| @Override | |||
| public IREdge getEdgeBetween(final String srcVertexId, | |||
| final String dstVertexId) throws IllegalEdgeOperationException { | |||
There was a problem hiding this comment.
As far as I can check, this change has to be made on both the common/src/main/java/org/apache/nemo/common/dag/DAG.java and the common/src/main/java/org/apache/nemo/common/dag/DAGInterface.java files, as mentioned here Could you check and confirm and make the appropriate changes there, if applicable? Thanks! 😄
| @@ -27,7 +27,7 @@ | |||
| * Abstract class for optimization passes. All passes basically extends this class. | |||
| */ | |||
| public abstract class Pass implements Serializable { | |||
| private Predicate<IRDAG> condition; | |||
| private Predicate<IRDAG> condition; //NOSONAR | |||
There was a problem hiding this comment.
For this, let's leave this line as-is, and remove the Serializable tag on line 29. This makes more sense. Please remove the implements Serializable on line 29, and revert the change on line 30. This will solve the issue.
| private final PCollection<KV<Integer, KV<int[], float[]>>> parsedUserData; | ||
| private final PCollection<KV<Integer, KV<int[], float[]>>> parsedItemData; | ||
| private final PCollection<KV<Integer, KV<int[], float[]>>> parsedUserData; //NOSONAR | ||
| private final PCollection<KV<Integer, KV<int[], float[]>>> parsedItemData; //NOSONAR |
There was a problem hiding this comment.
For these lines, let's declare the variables transient, instead of putting //nosonar here. In that case, you would have to declare private final transient PCollection... for both lines. Thanks!
|
@kdh9949 I've left some comments |
|
Don't forget to address the comments! @kdh9949 @jangsus1 @geeglegeegle45 @Kojihyung |
JIRA: NEMO-429: TEAM11
Major changes:
Co-authored-by: wonook wonook@apache.org