New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEMO-429] SWPP TEAM 13 code smell fix #285
Conversation
…teral people 4 times.
…teral Name: 3 times.
code smell resolved: Replace this lambda with a method reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also check the test failures?
@@ -32,6 +32,8 @@ | |||
* @param <T> type of the object to serialize. | |||
*/ | |||
public final class SparkEncoderFactory<T> implements EncoderFactory<T> { | |||
// NOSONAR | |||
// Serializer is implicitly serilizable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
@@ -62,6 +64,8 @@ public String toString() { | |||
*/ | |||
private final class SparkEncoder<T2> implements Encoder<T2> { | |||
|
|||
// NOSONAR | |||
// SerializationStream is implicitly serilizable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
@jeongyooneo Any plans on this PR? |
Won't merge this PR. |
JIRA: NEMO-429: SWPP TEAM 13 code smell fix
Major changes: