Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEMO-429] SWPP TEAM 13 code smell fix #285

Closed
wants to merge 14 commits into from
Closed

[NEMO-429] SWPP TEAM 13 code smell fix #285

wants to merge 14 commits into from

Conversation

jeongyooneo
Copy link
Contributor

JIRA: NEMO-429: SWPP TEAM 13 code smell fix

Major changes:

  • Fixed code smells (SWPP Code Smell session)

@jeongyooneo jeongyooneo self-assigned this Feb 9, 2020
Copy link
Member

@wonook wonook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also check the test failures?

@@ -32,6 +32,8 @@
* @param <T> type of the object to serialize.
*/
public final class SparkEncoderFactory<T> implements EncoderFactory<T> {
// NOSONAR
// Serializer is implicitly serilizable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@@ -62,6 +64,8 @@ public String toString() {
*/
private final class SparkEncoder<T2> implements Encoder<T2> {

// NOSONAR
// SerializationStream is implicitly serilizable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@wonook
Copy link
Member

wonook commented Apr 20, 2020

@jeongyooneo Any plans on this PR?

@bgchun
Copy link

bgchun commented Dec 1, 2020

Won't merge this PR.

@bgchun bgchun closed this Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants