-
Notifications
You must be signed in to change notification settings - Fork 844
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[NETBEANS-1675]Java Hint to fix error :different case kinds used in s… (
#1126) * [NETBEANS-1675]Java Hint to fix error :different case kinds used in switch expressions * Use getBody method * Add review comment changes * Change hint message
- Loading branch information
1 parent
f718d2a
commit a91ade4
Showing
18 changed files
with
1,073 additions
and
196 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
143 changes: 143 additions & 0 deletions
143
java/java.hints/src/org/netbeans/modules/java/hints/errors/DifferentCaseKindsFix.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,143 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| package org.netbeans.modules.java.hints.errors; | ||
|
|
||
| import com.sun.source.tree.CaseTree; | ||
| import com.sun.source.tree.SwitchTree; | ||
| import com.sun.source.tree.Tree; | ||
| import com.sun.source.util.TreePath; | ||
| import java.util.Arrays; | ||
| import java.util.Collections; | ||
| import java.util.HashSet; | ||
| import java.util.List; | ||
| import java.util.Set; | ||
| import org.netbeans.api.java.queries.CompilerOptionsQuery; | ||
| import org.netbeans.api.java.source.CompilationInfo; | ||
| import org.netbeans.modules.java.hints.spi.ErrorRule; | ||
| import org.netbeans.modules.java.source.TreeShims; | ||
| import org.netbeans.spi.editor.hints.Fix; | ||
| import org.netbeans.spi.java.hints.JavaFix; | ||
| import org.netbeans.spi.java.hints.JavaFix.TransformationContext; | ||
| import org.openide.util.NbBundle; | ||
|
|
||
| /** | ||
| * Handle error rule "compiler.err.switch.mixing.case.types" and provide the | ||
| * fix. | ||
| * | ||
| * @author vkprabha | ||
| */ | ||
| public class DifferentCaseKindsFix implements ErrorRule<Void> { | ||
|
|
||
| private static final Set<String> ERROR_CODES = new HashSet<String>(Arrays.asList( | ||
| "compiler.err.switch.mixing.case.types")); // NOI18N | ||
|
|
||
| @Override | ||
| public Set<String> getCodes() { | ||
| return Collections.unmodifiableSet(ERROR_CODES); | ||
| } | ||
|
|
||
| @Override | ||
| public List<Fix> run(CompilationInfo info, String diagnosticKey, int offset, TreePath treePath, Data<Void> data) { | ||
| if (!CompilerOptionsQuery.getOptions(info.getFileObject()).getArguments().contains("--enable-preview")) { | ||
| return null; | ||
| } | ||
| TreePath parentPath = treePath.getParentPath(); | ||
| List<? extends CaseTree> caseTrees = null; | ||
| boolean flag = false; | ||
| if(parentPath.getLeaf().getKind().toString().equals("SWITCH_EXPRESSION")){ | ||
| caseTrees = TreeShims.getCases(parentPath.getLeaf()); | ||
| } else { | ||
| flag = true; | ||
| caseTrees = ((SwitchTree) treePath.getParentPath().getLeaf()).getCases(); | ||
| } | ||
| boolean completesNormally = false; | ||
| boolean wasDefault = false; | ||
| boolean wasEmpty = false; | ||
| for (CaseTree ct : caseTrees) { | ||
| if (ct.getStatements() == null && TreeShims.getBody(ct) == null) { | ||
| return null; | ||
| } else if (flag && ct.getStatements() != null) { | ||
| if (completesNormally) { | ||
| if (!wasEmpty) {//fall-through from a non-empty case | ||
| return null; | ||
| } | ||
| if (wasDefault) {//fall-through from default to a case | ||
| return null; | ||
| } | ||
| if (!wasDefault && ct.getExpression() == null) {//fall-through from a case to default | ||
| return null; | ||
| } | ||
| } | ||
| completesNormally = Utilities.completesNormally(info, new TreePath(treePath.getParentPath(), ct)); | ||
| wasDefault = ct.getExpression() == null; | ||
| wasEmpty = ct.getStatements().isEmpty(); | ||
| } | ||
| } | ||
|
|
||
| return Collections.<Fix>singletonList(new DifferentCaseKindsFix.FixImpl(info, treePath).toEditorFix()); | ||
| } | ||
|
|
||
| @Override | ||
| public String getId() { | ||
| return DifferentCaseKindsFix.class.getName(); | ||
| } | ||
|
|
||
| @Override | ||
| public String getDisplayName() { | ||
| return NbBundle.getMessage(DifferentCaseKindsFix.class, "FIX_DifferentCaseKinds"); // NOI18N | ||
| } | ||
|
|
||
| public String getDescription() { | ||
| return NbBundle.getMessage(DifferentCaseKindsFix.class, "FIX_DifferentCaseKinds"); // NOI18N | ||
| } | ||
|
|
||
| @Override | ||
| public void cancel() { | ||
| } | ||
|
|
||
| private static final class FixImpl extends JavaFix { | ||
|
|
||
| CompilationInfo info; | ||
| TreePath path; | ||
|
|
||
| public FixImpl(CompilationInfo info, TreePath path) { | ||
| super(info, path); | ||
| this.info = info; | ||
| this.path = path; | ||
| } | ||
|
|
||
| @Override | ||
| protected String getText() { | ||
| return NbBundle.getMessage(DifferentCaseKindsFix.class, "FIX_DifferentCaseKinds"); // NOI18N | ||
| } | ||
|
|
||
| public String toDebugString() { | ||
| return NbBundle.getMessage(DifferentCaseKindsFix.class, "FIX_DifferentCaseKinds"); // NOI18N | ||
| } | ||
|
|
||
| @Override | ||
| protected void performRewrite(TransformationContext ctx) { | ||
| TreePath tp = ctx.getPath(); | ||
| Tree switchBlock = tp.getParentPath().getLeaf(); | ||
| Utilities.performRewriteRuleSwitch(ctx, tp, switchBlock); | ||
| } | ||
|
|
||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.