-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate enterprise cluster and disable modules with incompatible licenses #1104
Conversation
I'm looking into the build failures. |
Both libraries are provided by a module in the ide cluster
wildfly depends on LGPL files at this point in time and thus can't be released from the apache netbeans project.
abd2069
to
801dfec
Compare
The travis build is green now. There were remaining dependencies that referenced the disabled modules and metro.model needs to be removed to, as it depends on wsit. I did not go through the EE modules though. |
Makes sense. I vote to merge and then to take it from there, now that everything is green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thank you both for checking - lets see how the fallout will look. |
I've unzipped the latest build that includes the enterprise cluster. Something isn't working quite right with the enablement, i.e., when clicking Next in 'Java Web' or 'Java EE' in the New Project dialog, to enable the feature, the 'Finding Feature' dialog appears and messages of 'Not all requested modules can be installed' appears, starting with org.netbeans.modules.web.primefaces. |
Yes I see, it can be reproduced locally to. However, manually enabling JavaEE in the plugin manager correctly enabled the feature and then the error is gone. It would be great if some one with a bit more experience in the black magic of automatic feature enablement (is that ergonomics?) could have a look. |
Update: please clear the userdir. I ran |
I can still reproduce it, though I started by downloading the ZIP from the artifacts on Jenkins, then ran with a fresh user directory, and can still see the same problem. |
Definitely was a network issue of some kind, VPN, etc. |
PR #1098 activates the enterprise cluster. There are however modules,
that have dependencies on incompatible license (wildfly + jboss LGPL,
weblogic 9 commercial, wsit OASIS license). PR #1101 removes some,
but skips wildfly (it is indicated, that red hat might be willing to relax
licensing for the DTDs/XSDs).
In the current state however the module does not qualify and thus is
disabled.
The enterprise cluster also includes some libraries, that need either
adjustment to use common dependencies or adjustments in the build
system to tollerate duplicate libraries.
This PR merges the work from #1098, #1101 and adds the described
pieces. In combination this should let the travis builds succeed.
Please do not squash this, I'll merge myself, when reviewed.
Closes: #1098
Closes: #1101