New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate enterprise cluster and disable modules with incompatible licenses #1104

Merged
merged 9 commits into from Jan 27, 2019

Conversation

Projects
None yet
3 participants
@matthiasblaesing
Copy link
Contributor

matthiasblaesing commented Jan 26, 2019

PR #1098 activates the enterprise cluster. There are however modules,
that have dependencies on incompatible license (wildfly + jboss LGPL,
weblogic 9 commercial, wsit OASIS license). PR #1101 removes some,
but skips wildfly (it is indicated, that red hat might be willing to relax
licensing for the DTDs/XSDs).

In the current state however the module does not qualify and thus is
disabled.

The enterprise cluster also includes some libraries, that need either
adjustment to use common dependencies or adjustments in the build
system to tollerate duplicate libraries.

This PR merges the work from #1098, #1101 and adds the described
pieces. In combination this should let the travis builds succeed.

Please do not squash this, I'll merge myself, when reviewed.

Closes: #1098
Closes: #1101

@matthiasblaesing matthiasblaesing requested review from lkishalmi and geertjanw Jan 26, 2019

@matthiasblaesing

This comment has been minimized.

Copy link
Contributor Author

matthiasblaesing commented Jan 26, 2019

I'm looking into the build failures.

@matthiasblaesing matthiasblaesing force-pushed the matthiasblaesing:pr-1098 branch from abd2069 to 801dfec Jan 27, 2019

@matthiasblaesing

This comment has been minimized.

Copy link
Contributor Author

matthiasblaesing commented Jan 27, 2019

The travis build is green now. There were remaining dependencies that referenced the disabled modules and metro.model needs to be removed to, as it depends on wsit. I did not go through the EE modules though.

@geertjanw

This comment has been minimized.

Copy link
Member

geertjanw commented Jan 27, 2019

Makes sense. I vote to merge and then to take it from there, now that everything is green.

@lkishalmi
Copy link
Contributor

lkishalmi left a comment

Looks good to me.

@matthiasblaesing

This comment has been minimized.

Copy link
Contributor Author

matthiasblaesing commented Jan 27, 2019

Thank you both for checking - lets see how the fallout will look.

@matthiasblaesing matthiasblaesing merged commit d6db05b into apache:master Jan 27, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@geertjanw

This comment has been minimized.

Copy link
Member

geertjanw commented Jan 27, 2019

I've unzipped the latest build that includes the enterprise cluster. Something isn't working quite right with the enablement, i.e., when clicking Next in 'Java Web' or 'Java EE' in the New Project dialog, to enable the feature, the 'Finding Feature' dialog appears and messages of 'Not all requested modules can be installed' appears, starting with org.netbeans.modules.web.primefaces.

@matthiasblaesing

This comment has been minimized.

Copy link
Contributor Author

matthiasblaesing commented Jan 27, 2019

Yes I see, it can be reproduced locally to. However, manually enabling JavaEE in the plugin manager correctly enabled the feature and then the error is gone. It would be great if some one with a bit more experience in the black magic of automatic feature enablement (is that ergonomics?) could have a look.

@matthiasblaesing

This comment has been minimized.

Copy link
Contributor Author

matthiasblaesing commented Jan 27, 2019

Update: please clear the userdir. I ran ant tryme after I removed nbbuild/testuserdir/. After that I'm correctly asked do "Download and activate" the feature.

@geertjanw

This comment has been minimized.

Copy link
Member

geertjanw commented Jan 27, 2019

I can still reproduce it, though I started by downloading the ZIP from the artifacts on Jenkins, then ran with a fresh user directory, and can still see the same problem.

@matthiasblaesing matthiasblaesing deleted the matthiasblaesing:pr-1098 branch Jan 27, 2019

@geertjanw

This comment has been minimized.

Copy link
Member

geertjanw commented Jan 28, 2019

Definitely was a network issue of some kind, VPN, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment