Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-1969]:Fixed reindentation issues for Switch Rule-Case and S… #1124

Merged
merged 3 commits into from
Feb 14, 2019

Conversation

arusinha-zz
Copy link

@arusinha-zz arusinha-zz commented Feb 8, 2019

…witch Expression(JDK-12)

Jira Link :
https://issues.apache.org/jira/browse/NETBEANS-1969

break;
case "SWITCH_EXPRESSION": {
try {
Class swExprTreeClass = Class.forName("com.sun.source.tree.SwitchExpressionTree");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use "// NOI18N" comment for hard coded strings

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TreeShims is planned to be removed in future , so i believe // NOI18N" is not required

Copy link
Contributor

@jlahoda jlahoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

@arusinha-zz arusinha-zz merged commit fccdbb2 into apache:master Feb 14, 2019
@arusinha-zz arusinha-zz added the Cherry Pick Consider cherry picking for release update label Feb 19, 2019
@lkishalmi lkishalmi removed the Cherry Pick Consider cherry picking for release update label Feb 26, 2019
lkishalmi pushed a commit that referenced this pull request Feb 26, 2019
[NETBEANS-1969]:Fixed reindentation issues for Switch Rule-Case and S…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants