[NETBEANS-2038] Do not dump ambiguous output when a build is cancelled. #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlahoda
reviewed
Feb 17, 2019
| @@ -69,6 +69,9 @@ | |||
| private static final Logger LOGGER = Logger.getLogger(GradleDaemonExecutor.class.getName()); | |||
|
|
|||
| private final ProgressHandle handle; | |||
| private OutputStream outStream; | |||
There was a problem hiding this comment.
So, assuming the cancel can be asynchronous, I wonder if there's a need for synchronization for these fields?
| // This can happen if cancelling a Gradle build which is running | ||
| // an external aplication | ||
| showAbort(); | ||
| } | ||
| //TODO: Handle Cancelled builds |
There was a problem hiding this comment.
Nit: these comments are probably obsolete now?
| boolean esc; | ||
| boolean csi; | ||
| boolean closed = false; |
There was a problem hiding this comment.
I wonder if some kind of synchronization is needed for the field? (Maybe AtomicBoolean instead of plain boolean?)
lkishalmi
force-pushed
the
NETBEANS-2038_Anomalous_termination_of_gradle_task
branch
from
07bb600
to
011f78f
Compare
|
@jlahoda Thanks for the review. You are right it is better to be safe than sorry. I've applied the requested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.