[NETBEANS-2418][NETBEANS-2298] update suggested MySQL Driver to latest #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure, but looking at Travis: But theres no errors and the end of the logs say: Are we running too many checks in these Travis builds? |
|
Could be John. The changes themselves look just fine. Will check the mailing lists to see if this is a known thing too. On mobile right now. |
|
One think that the driver reminded me at work: The driver class was moved to |
|
I didn't come across a change to the class when testing but will double check before merging to be sure |
|
It is more likely a deprecation warning https://dev.mysql.com/doc/connector-j/8.0/en/connector-j-api-changes.html Notice the old class name is deprecated. I would not expect tests to fail, but it makes sense to update. |
…o the polyglot API documentation
[NETBEANS-2573] Pass files to test in env variable
Allow any kind of Mode to be created programatically from a ModeConfig XML String so that a TopComponent may then be programatically docked into that Mode.
…st be found (message + stacktrace) - stacktrace may be empty
[NETBEANS-1638] export org.apache.felix.resolver.reason
[NETBEANS-1851] PHPUnit java.lang.AssertionError: At least 2 lines must be found (message + stacktrace)
…e engines used for PAC script evaluation
NETBEANS-2565: ide.ks file tracked again as part of updatecenters module
[NETBEANS-2361] Fix app.conf and launcher on macOS after changes in #573
One of those deprecated warnings is "getURL() in FileObject has been deprecated". This work is simply to remove these warnings and make the build less noisy.
[NETBEANS-2783] Fix missing dependencies nodes in Project view when editing POM file
…ts. (#1329) * [NETBEANS-2729] Let's development and release snap descriptors co-exists
Update htmlparser/lexer to support html5 attribute syntax
Fix ClassPathTest in ide/api.java.classpath module
[NETBEANS-2845] Update URLs of README.html
[NETBEANS-2881] Prevent java.lang.StringIndexOutOfBoundsException
… platform dependent ones, makin it default. (#1349)
…on of javax.lang.model.element.ModuleElement, when the available javac is not new enough.
…e redirecting / release templating Re-add special 3rd-party UC and 8.2 centre while still required in releases
…-brackets [NETBEANS-2910] Suggest using brackets for accessing arrays instead of curly braces
Fix update centre links in master
The references issue found cases, where the CSS grammar lead to an inifite backtracking loop. This patch works around that limitation by requireing that the parsing progresses. The implementation counts the read calls issued without progressing through the stream. If the read count withouth progress exceeds 10.000.000 reads, parsing is stopped. The number was found experimentally - it needs to be large enough to handle real world cases and low enough that progress happens early enough.
[NETBEANS-1047] Don't add whitespace to a wrong place when textual operators are used
- Allow empty level option to use a level of a configuration file
[NETBEANS-2974] PHPStan - make level optional
…eflect suggested MySQL v8 driver
…om/mcdonnell-john/netbeans into feature/some-mysql-related-changes
|
Closing due to re-basing issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a defect related to the JDBC Connection String for MySQL, I took a look and noticed we were suggesting an older driver.
I've updated the suggested driver to the latest, and ran some CRUD DB tests with it with NB 11.0 with no issues